[glib] gparam: Remove unnecessary conditionals around preconditions



commit 09498e52bbc71496cd1b99ad5c8781783a864881
Author: Colin Walters <walters verbum org>
Date:   Thu Jun 12 13:37:16 2014 -0400

    gparam: Remove unnecessary conditionals around preconditions
    
    These cause a static analyzer to think we're trying to actually handle
    them being NULL, which is not the case.  They both must not be NULL,
    period.
    
    No idea why the code was like this originally.
    
    Reviewed by mclasen on IRC.

 gobject/gparam.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)
---
diff --git a/gobject/gparam.c b/gobject/gparam.c
index 80a553b..c69ee02 100644
--- a/gobject/gparam.c
+++ b/gobject/gparam.c
@@ -1062,11 +1062,8 @@ g_param_spec_pool_lookup (GParamSpecPool *pool,
   GParamSpec *pspec;
   gchar *delim;
 
-  if (!pool || !param_name)
-    {
-      g_return_val_if_fail (pool != NULL, NULL);
-      g_return_val_if_fail (param_name != NULL, NULL);
-    }
+  g_return_val_if_fail (pool != NULL, NULL);
+  g_return_val_if_fail (param_name != NULL, NULL);
 
   g_mutex_lock (&pool->mutex);
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]