[metacity] Fix new window focus https://bugzilla.gnome.org/show_bug.cgi?id=534752

[Alberts Muktupāvels <muktupavels src gnome org>]

commit cd481d37ec2551e98db758ff640d02f3745259db
Author: Alberts Muktupāvels <alberts muktupavels gmail com>
Date:   Wed Jun 4 09:19:19 2014 +0300

    Fix new window focus
    https://bugzilla.gnome.org/show_bug.cgi?id=534752

 src/core/window.c |   20 +++++++++++++-------
 1 files changed, 13 insertions(+), 7 deletions(-)
---
diff --git a/src/core/window.c b/src/core/window.c
index b1555b9..f24d8af 100644
--- a/src/core/window.c
+++ b/src/core/window.c
@@ -2043,6 +2043,10 @@ static gboolean
 windows_overlap (const MetaWindow *w1, const MetaWindow *w2)
 {
   MetaRectangle w1rect, w2rect;
+
+  if (w1->minimized || w2->minimized)
+    return FALSE;
+
   meta_window_get_outer_rect (w1, &w1rect);
   meta_window_get_outer_rect (w2, &w2rect);
   return meta_rectangle_overlap (&w1rect, &w2rect);
@@ -2097,6 +2101,7 @@ meta_window_show (MetaWindow *window)
   gboolean takes_focus_on_map;
   gboolean place_on_top_on_map;
   gboolean needs_stacking_adjustment;
+  gboolean will_be_covered;
   MetaWindow *focus_window;
   guint32     timestamp;
 
@@ -2114,6 +2119,7 @@ meta_window_show (MetaWindow *window)
   did_show = FALSE;
   window_state_on_map (window, &takes_focus_on_map, &place_on_top_on_map);
   needs_stacking_adjustment = FALSE;
+  will_be_covered = window_would_be_covered (window);
 
   meta_topic (META_DEBUG_WINDOW_STATE,
               "Window %s %s focus on map, and %s place on top on map.\n",
@@ -2134,7 +2140,7 @@ meta_window_show (MetaWindow *window)
 
   if ( focus_window != NULL && window->showing_for_first_time &&
       ( (!place_on_top_on_map && !takes_focus_on_map) ||
-      window_would_be_covered (window) )
+      will_be_covered )
     ) {
       if (meta_window_is_ancestor_of_transient (focus_window, window))
         {
@@ -2218,21 +2224,21 @@ meta_window_show (MetaWindow *window)
        * in the stack when it doesn't overlap it confusingly places
        * that new window below a lot of other windows.
        */
-      if (overlap || 
+      if (!will_be_covered && (overlap ||
           (meta_prefs_get_focus_mode () == G_DESKTOP_FOCUS_MODE_CLICK &&
-           meta_prefs_get_raise_on_click ()))
+           meta_prefs_get_raise_on_click ())))
         meta_window_stack_just_below (window, focus_window);
 
-      /* If the window will be obscured by the focus window, then the
-       * user might not notice the window appearing so set the
-       * demands attention hint.
+      /* If the window will be obscured by the focus window or a window set to
+       * always on top, then the user might not notice the window appearing so
+       * set the demands attention hint.
        *
        * We set the hint ourselves rather than calling 
        * meta_window_set_demands_attention() because that would cause
        * a recalculation of overlap, and a call to set_net_wm_state()
        * which we are going to call ourselves here a few lines down.
        */
-      if (overlap)
+      if (overlap || will_be_covered)
         window->wm_state_demands_attention = TRUE;
     }