[gtk+] textbuffer: emit notify signal for the "text" property
- From: Sébastien Wilmet <swilmet src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk+] textbuffer: emit notify signal for the "text" property
- Date: Tue, 29 Jul 2014 13:22:07 +0000 (UTC)
commit 8ad9cf8b8c0ad0106e8cdd83f17e2627bf9226cf
Author: Sébastien Wilmet <swilmet gnome org>
Date: Sun Jul 20 15:44:12 2014 +0200
textbuffer: emit notify signal for the "text" property
Although there is the "changed" signal, it is more correct to notify the
"text" property too. It can be useful for a small text view, where the
text is saved e.g. to gsettings with a binding to the text property.
The "text" property includes only the text, not child widgets or images,
so the notify signal is sent too many times (also for child widgets and
images), but it's not a big problem.
https://bugzilla.gnome.org/show_bug.cgi?id=624791
gtk/gtktextbuffer.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/gtk/gtktextbuffer.c b/gtk/gtktextbuffer.c
index 0af7cf7..672353c 100644
--- a/gtk/gtktextbuffer.c
+++ b/gtk/gtktextbuffer.c
@@ -878,8 +878,6 @@ gtk_text_buffer_set_text (GtkTextBuffer *buffer,
gtk_text_buffer_get_iter_at_offset (buffer, &start, 0);
gtk_text_buffer_insert (buffer, &start, text, len);
}
-
- g_object_notify (G_OBJECT (buffer), "text");
}
@@ -2545,6 +2543,8 @@ static void
gtk_text_buffer_real_changed (GtkTextBuffer *buffer)
{
gtk_text_buffer_set_modified (buffer, TRUE);
+
+ g_object_notify (G_OBJECT (buffer), "text");
}
static void
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]