[gtk+/gtk-2-24] GtkEntry: Properly remove the completion timeout



commit 3c8f0c44e149f9fc3c20a7a0aba6d4f578a1acf7
Author: Matthias Clasen <mclasen redhat com>
Date:   Tue Jul 29 12:23:13 2014 +0200

    GtkEntry: Properly remove the completion timeout
    
    There were some code paths where we removed the source, but
    failed to reset the id to zero.
    
    Pointed out by John Coppens in
    https://bugzilla.gnome.org/show_bug.cgi?id=733689

 gtk/gtkentry.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
---
diff --git a/gtk/gtkentry.c b/gtk/gtkentry.c
index b55bd89..f2a6328 100644
--- a/gtk/gtkentry.c
+++ b/gtk/gtkentry.c
@@ -9607,7 +9607,10 @@ gtk_entry_completion_changed (GtkWidget *entry,
 
   /* (re)install completion timeout */
   if (completion->priv->completion_timeout)
-    g_source_remove (completion->priv->completion_timeout);
+    {
+      g_source_remove (completion->priv->completion_timeout);
+      completion->priv->completion_timeout = 0;
+    }
 
   if (!gtk_entry_get_text (GTK_ENTRY (entry)))
     return;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]