[gnumeric] xls: fix export problem in DIMENSION record.



commit 229c8156577ea22b5e8788577cbce67a210b446e
Author: Morten Welinder <terra gnome org>
Date:   Sun Jul 27 16:53:54 2014 -0400

    xls: fix export problem in DIMENSION record.

 NEWS                           |    3 +++
 plugins/excel/ChangeLog        |    5 +++++
 plugins/excel/ms-excel-write.c |    8 ++++----
 3 files changed, 12 insertions(+), 4 deletions(-)
---
diff --git a/NEWS b/NEWS
index 3d63579..0e2fa2d 100644
--- a/NEWS
+++ b/NEWS
@@ -3,6 +3,9 @@ Gnumeric 1.12.18
 Andreas:
        * Improve documentation. [#733466]
 
+Morten:
+       * Fix xls export problem.  [#733771]
+
 --------------------------------------------------------------------------
 Gnumeric 1.12.17
 
diff --git a/plugins/excel/ChangeLog b/plugins/excel/ChangeLog
index 18bd9ae..1249610 100644
--- a/plugins/excel/ChangeLog
+++ b/plugins/excel/ChangeLog
@@ -1,3 +1,8 @@
+2014-07-27  Morten Welinder  <terra gnome org>
+
+       * ms-excel-write.c (excel_write_DIMENSION): Fix off-by-one, see
+       #733771.
+
 2014-06-09  Morten Welinder <terra gnome org>
 
        * Release 1.12.17
diff --git a/plugins/excel/ms-excel-write.c b/plugins/excel/ms-excel-write.c
index 77dea7e..64b49cb 100644
--- a/plugins/excel/ms-excel-write.c
+++ b/plugins/excel/ms-excel-write.c
@@ -5042,16 +5042,16 @@ excel_write_DIMENSION (BiffPut *bp, ExcelWriteSheet *esheet)
        if (bp->version >= MS_BIFF_V8) {
                data = ms_biff_put_len_next (bp, BIFF_DIMENSIONS_v2, 14);
                GSF_LE_SET_GUINT32 (data +  0, 0);
-               GSF_LE_SET_GUINT32 (data +  4, esheet->max_row-1);
+               GSF_LE_SET_GUINT32 (data +  4, esheet->max_row);
                GSF_LE_SET_GUINT16 (data +  8, 0);
-               GSF_LE_SET_GUINT16 (data + 10, esheet->max_col-1);
+               GSF_LE_SET_GUINT16 (data + 10, esheet->max_col);
                GSF_LE_SET_GUINT16 (data + 12, 0x0000);
        } else {
                data = ms_biff_put_len_next (bp, BIFF_DIMENSIONS_v2, 10);
                GSF_LE_SET_GUINT16 (data +  0, 0);
-               GSF_LE_SET_GUINT16 (data +  2, esheet->max_row-1);
+               GSF_LE_SET_GUINT16 (data +  2, esheet->max_row);
                GSF_LE_SET_GUINT16 (data +  4, 0);
-               GSF_LE_SET_GUINT16 (data +  6, esheet->max_col-1);
+               GSF_LE_SET_GUINT16 (data +  6, esheet->max_col);
                GSF_LE_SET_GUINT16 (data +  8, 0x0000);
        }
        ms_biff_put_commit (bp);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]