[libxml2] xmlcatalog: Fix a memory leak on quit



commit 7746f2f60982889cd836fc23022e426f5a02d883
Author: Philip Withnall <philip withnall collabora co uk>
Date:   Fri Jun 20 21:05:33 2014 +0100

    xmlcatalog: Fix a memory leak on quit
    
    Coverity issue: #60442
    
    https://bugzilla.gnome.org/show_bug.cgi?id=731990

 xmlcatalog.c |   11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)
---
diff --git a/xmlcatalog.c b/xmlcatalog.c
index 43f455a..b9ed6a4 100644
--- a/xmlcatalog.c
+++ b/xmlcatalog.c
@@ -181,12 +181,13 @@ static void usershell(void) {
        /*
         * start interpreting the command
         */
-        if (!strcmp(command, "exit"))
-           break;
-        if (!strcmp(command, "quit"))
-           break;
-        if (!strcmp(command, "bye"))
+       if (!strcmp(command, "exit") ||
+           !strcmp(command, "quit") ||
+           !strcmp(command, "bye")) {
+           free(cmdline);
            break;
+       }
+
        if (!strcmp(command, "public")) {
            if (nbargs != 1) {
                printf("public requires 1 arguments\n");


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]