[glade/glade-3-18] Avoid reading freed data in glade_project_read_requires



commit d00ece8aa71332930e4a2d0d490d175567dbde36
Author: David Shea <dshea redhat com>
Date:   Wed Jul 23 17:34:02 2014 -0400

    Avoid reading freed data in glade_project_read_requires
    
    Ensure that required_lib is NULL at the start of each iteration through
    the loop.

 gladeui/glade-project.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
---
diff --git a/gladeui/glade-project.c b/gladeui/glade-project.c
index eecdb86..e91b0cb 100644
--- a/gladeui/glade-project.c
+++ b/gladeui/glade-project.c
@@ -1435,7 +1435,6 @@ glade_project_read_requires (GladeProject *project,
 
   GString *string = g_string_new (NULL);
   GladeXmlNode *node;
-  gchar *required_lib = NULL;
   gboolean loadable = TRUE;
   guint16 major, minor;
   gint position = 0;
@@ -1443,6 +1442,8 @@ glade_project_read_requires (GladeProject *project,
   for (node = glade_xml_node_get_children_with_comments (root_node);
        node; node = glade_xml_node_next_with_comments (node))
     {
+      gchar *required_lib = NULL;
+
       /* Skip non "requires" tags */
       if (!(glade_xml_node_verify_silent (node, GLADE_XML_TAG_REQUIRES) ||
             (required_lib =


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]