[evolution-ews/evolution-ews-3-12] Bug 732850 - Remove reachability check from ews_store_query_auth_types_sync()



commit 53ea2278d72962e9a94941a6ceb043a48f72eb98
Author: Daniel Sands <dnsands sandia gov>
Date:   Tue Jul 22 16:56:38 2014 +0100

    Bug 732850 - Remove reachability check from ews_store_query_auth_types_sync()
    
    The auth method discovery code first checks whether the "host" is
    reachable. This will always fail because it only sets its Host URL for
    the service, and the camel code relies on the host and port itself being
    set before it can answer that question.  Even after setting the host and
    port, it is necessary to give the underlying system time to query the
    network service.  So this check should not be done at all.
    
    [dwmw2: The check is entirely redundant anyway. Even after we rip it out,
            I've confirmed that we still get coherent errors reported in the
            UI, telling us that we were unabled to resolve or reach the server.]
    
    (cherry picked from commit f392e0b225f77c4f8d670b5ad9ff3016a7ef94b5)

 src/camel/camel-ews-store.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)
---
diff --git a/src/camel/camel-ews-store.c b/src/camel/camel-ews-store.c
index 4f4d123..3029665 100644
--- a/src/camel/camel-ews-store.c
+++ b/src/camel/camel-ews-store.c
@@ -1887,14 +1887,6 @@ ews_store_query_auth_types_sync (CamelService *service,
 
        g_return_val_if_fail (CAMEL_IS_EWS_STORE (service), NULL);
 
-       if (!camel_offline_store_get_online (CAMEL_OFFLINE_STORE (service))) {
-               g_set_error (
-                       error, CAMEL_SERVICE_ERROR,
-                       CAMEL_SERVICE_ERROR_UNAVAILABLE,
-                       _("You must be working online to complete this operation"));
-               return NULL;
-       }
-
        settings = camel_service_ref_settings (service);
        ews_settings = CAMEL_EWS_SETTINGS (settings);
        hosturl = camel_ews_settings_dup_hosturl (ews_settings);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]