[geary] Strip and lowercase email addrs for Gravatar: Bug #732718



commit 21bad376fa0642ab5b578542f497f896970c1aa7
Author: Jim Nelson <jim yorba org>
Date:   Tue Jul 8 14:18:23 2014 -0700

    Strip and lowercase email addrs for Gravatar: Bug #732718
    
    As per Gravatar's spec.

 src/client/util/util-gravatar.vala |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)
---
diff --git a/src/client/util/util-gravatar.vala b/src/client/util/util-gravatar.vala
index 52f8db3..e20de96 100644
--- a/src/client/util/util-gravatar.vala
+++ b/src/client/util/util-gravatar.vala
@@ -53,8 +53,11 @@ public enum Default {
  * https://en.gravatar.com/site/implement/images/
  */
 public string get_image_uri(Geary.RFC822.MailboxAddress addr, Default def, int size = DEFAULT_SIZE) {
-    return "http://www.gravatar.com/avatar/%s?d=%s&s=%d".printf(
-        Checksum.compute_for_string(ChecksumType.MD5, addr.address), def.to_param(), size);
+    // Gravatar spec for preparing address and hashing:
+    // http://en.gravatar.com/site/implement/hash/
+    string md5 = Checksum.compute_for_string(ChecksumType.MD5, addr.address.strip().down());
+    
+    return "http://www.gravatar.com/avatar/%s?d=%s&s=%d".printf(md5, def.to_param(), size);
 }
 
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]