[gtk+] css: Fix animation-direction parsing



commit b6aecca71c8493b8068024863b8a8fabfb89216a
Author: Benjamin Otte <otte redhat com>
Date:   Mon Jul 7 19:44:59 2014 +0200

    css: Fix animation-direction parsing
    
    We were parsig "alternate-reverse" as "alternate" and then complaining
    about the "-reverse" junk at the end of the value.

 gtk/gtkcssenumvalue.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)
---
diff --git a/gtk/gtkcssenumvalue.c b/gtk/gtkcssenumvalue.c
index a8c807b..b131823 100644
--- a/gtk/gtkcssenumvalue.c
+++ b/gtk/gtkcssenumvalue.c
@@ -524,11 +524,14 @@ _gtk_css_direction_value_new (GtkCssDirection direction)
 GtkCssValue *
 _gtk_css_direction_value_try_parse (GtkCssParser *parser)
 {
-  guint i;
+  int i;
 
   g_return_val_if_fail (parser != NULL, NULL);
 
-  for (i = 0; i < G_N_ELEMENTS (direction_values); i++)
+  /* need to parse backwards here, otherwise "alternate" will also match "alternate-reverse".
+   * Our parser rocks!
+   */
+  for (i = G_N_ELEMENTS (direction_values) - 1; i >= 0; i--)
     {
       if (_gtk_css_parser_try (parser, direction_values[i].name, TRUE))
         return _gtk_css_value_ref (&direction_values[i]);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]