[totem] main: Remove FIXME



commit 41077fd6d1ef40aa979e700e79083ba5c1052fd4
Author: Bastien Nocera <hadess hadess net>
Date:   Thu Jan 30 19:44:10 2014 +0100

    main: Remove FIXME
    
    We don't need to unref() the popover as it gets attached to its
    "pointing-to" widget a-la gtk_container_add, so gtk_widget_destroy()
    on the parent will take care of destroying it.
    
    Above explanation paraphrased from Carlos Garnacho.

 src/totem-search-entry.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
---
diff --git a/src/totem-search-entry.c b/src/totem-search-entry.c
index 54c54bb..4ec77a0 100644
--- a/src/totem-search-entry.c
+++ b/src/totem-search-entry.c
@@ -49,8 +49,7 @@ totem_search_entry_finalize (GObject *obj)
        TotemSearchEntry *self = TOTEM_SEARCH_ENTRY (obj);
 
        g_clear_object (&self->priv->tag);
-       /* FIXME this causes a crash
-       g_clear_object (&self->priv->popover); */
+       /* The popover will be destroyed with it parent (us) */
 
        G_OBJECT_CLASS (totem_search_entry_parent_class)->finalize (obj);
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]