[gnome-shell] osdWindow: Don't tween to undefined



commit 7101cc3170bf727aebf918f37debff94ae705c85
Author: Jasper St. Pierre <jstpierre mecheye net>
Date:   Sun Apr 14 11:32:21 2013 -0400

    osdWindow: Don't tween to undefined
    
    Check that we got a valid level before setting the level bar to it, to
    prevent a Tweener warning.

 js/ui/osdWindow.js |   16 +++++++++-------
 1 files changed, 9 insertions(+), 7 deletions(-)
---
diff --git a/js/ui/osdWindow.js b/js/ui/osdWindow.js
index 199899f..1d10f80 100644
--- a/js/ui/osdWindow.js
+++ b/js/ui/osdWindow.js
@@ -125,13 +125,15 @@ const OsdWindow = new Lang.Class({
 
     setLevel: function(level) {
         this._level.actor.visible = (level != undefined);
-        if (this.actor.visible)
-            Tweener.addTween(this._level,
-                             { level: level,
-                               time: LEVEL_ANIMATION_TIME,
-                               transition: 'easeOutQuad' });
-        else
-            this._level.level = level;
+        if (level) {
+            if (this.actor.visible)
+                Tweener.addTween(this._level,
+                                 { level: level,
+                                   time: LEVEL_ANIMATION_TIME,
+                                   transition: 'easeOutQuad' });
+            else
+                this._level.level = level;
+        }
     },
 
     show: function() {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]