[gparted] Always show the File System Support dialog legend (#342682)



commit 59f684d8cdc5ea77f63e44ff8c92977647da2df5
Author: Mike Fleetwood <mike fleetwood googlemail com>
Date:   Sat Sep 28 09:17:39 2013 +0100

    Always show the File System Support dialog legend (#342682)
    
    Make the legend always shown, ready for when the dialog is resizable.
    
    Change the widget containing the legend from an expander to a frame
    widget.  Set the frame to be borderless using a bold label as
    recommended in the GNOME Human Interface Guidelines 2.2.1 / Controls /
    Frames and Separators.
    
        https://developer.gnome.org/hig-book/2.32/controls-frames.html.en
    
    Bug #342682 - too much information in 'features' dialog

 include/DialogFeatures.h |    4 ++--
 src/DialogFeatures.cc    |    8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)
---
diff --git a/include/DialogFeatures.h b/include/DialogFeatures.h
index 5f63450..475a39e 100644
--- a/include/DialogFeatures.h
+++ b/include/DialogFeatures.h
@@ -21,7 +21,7 @@
 #include "../include/Utils.h"
 
 #include <gtkmm/dialog.h>
-#include <gtkmm/expander.h>
+#include <gtkmm/frame.h>
 #include <gtkmm/treeview.h>
 #include <gtkmm/liststore.h>
 #include <gtkmm/image.h>
@@ -40,7 +40,7 @@ public:
 private:
        void show_filesystem( const FS & fs ) ;
 
-       Gtk::Expander expander_legend ;
+       Gtk::Frame legend_frame ;
        Gtk::TreeView treeview_filesystems;
        Gtk::TreeRow treerow;
        Glib::RefPtr<Gtk::ListStore> liststore_filesystems;
diff --git a/src/DialogFeatures.cc b/src/DialogFeatures.cc
index 751074d..6ce63e7 100644
--- a/src/DialogFeatures.cc
+++ b/src/DialogFeatures.cc
@@ -119,10 +119,10 @@ DialogFeatures::DialogFeatures()
        str_temp = "<b>" ;
        str_temp += _("Legend") ;
        str_temp += "</b>" ;
-       expander_legend .set_label( str_temp ) ;
-       expander_legend .set_use_markup( true ) ;
-       expander_legend .add( *legend_hbox ) ;
-       this ->get_vbox() ->pack_start( expander_legend, Gtk::PACK_SHRINK ) ;
+       legend_frame .set_label_widget( *Utils::mk_label( str_temp ) ) ;
+       legend_frame .set_shadow_type( Gtk::SHADOW_NONE ) ;
+       legend_frame .add( *legend_hbox ) ;
+       this ->get_vbox() ->pack_start( legend_frame, Gtk::PACK_SHRINK ) ;
 
        /*TO TRANSLATORS: This is a button that will search for the software tools installed and then refresh 
the screen with the file system actions supported. */
        add_button( _("Rescan For Supported Actions"), Gtk::RESPONSE_OK );


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]