[orca] Handle spin button value changes in the value-changed event callback



commit 60b55acf39a60b1ca7025a8e29e35a70046774fb
Author: Joanmarie Diggs <jdiggs igalia com>
Date:   Thu Jan 23 07:45:37 2014 -0500

    Handle spin button value changes in the value-changed event callback

 src/orca/scripts/default.py |   12 +-----------
 1 files changed, 1 insertions(+), 11 deletions(-)
---
diff --git a/src/orca/scripts/default.py b/src/orca/scripts/default.py
index 44e5e5b..3a83e57 100644
--- a/src/orca/scripts/default.py
+++ b/src/orca/scripts/default.py
@@ -2604,12 +2604,7 @@ class Script(script.Script):
         self.updateBraille(event.source)
 
         if event.source.getRole() == pyatspi.ROLE_SPIN_BUTTON:
-            # We cannot use the event.any_data due to a problem with
-            # selected text in spin buttons. See bug #520395 for more
-            # details.
-            #
-            [value, caret, start] = self.getTextLineAtCaret(event.source)
-            speech.speak(value)
+            # Value-changed events should not be handled here.
             return
 
         # If the last input event was a keyboard event, check to see if
@@ -2807,11 +2802,6 @@ class Script(script.Script):
         obj = event.source
         role = obj.getRole()
 
-        # We'll let caret moved and text inserted events be used to
-        # manage spin buttons, since they basically are text areas.
-        if role == pyatspi.ROLE_SPIN_BUTTON:
-            return
-
         value = obj.queryValue()
         if "oldValue" in self.pointOfReference \
            and (value.currentValue == self.pointOfReference["oldValue"]):


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]