[gnome-shell/gnome-3-10] altTab: Always filter out items with no windows



commit b28ea8ac9287480d4b67db94daf03074f7fa5522
Author: Florian Müllner <fmuellner gnome org>
Date:   Fri Jan 17 10:05:09 2014 -0500

    altTab: Always filter out items with no windows
    
    When restricting the switcher popup to the current workspace, we
    filter out running apps with an empty window list (namely: no open
    windows on the current workspace). However we may end up with an
    empty window list even when not restricting items to the current
    workspace when all windows of a running app are associated with a
    different application via the transient_for hint.
    To fix this, just filter out items with an empty window list
    unconditionally.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=722434

 js/ui/altTab.js |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/js/ui/altTab.js b/js/ui/altTab.js
index 779ae7b..86b06c7 100644
--- a/js/ui/altTab.js
+++ b/js/ui/altTab.js
@@ -454,9 +454,10 @@ const AppSwitcher = new Lang.Class({
             appIcon.cachedWindows = allWindows.filter(function(w) {
                 return windowTracker.get_window_app (w) == appIcon.app;
             });
-            if (workspace == null || appIcon.cachedWindows.length > 0) {
+            if (appIcon.cachedWindows.length > 0)
                 this._addIcon(appIcon);
-            }
+            else if (workspace == null)
+                throw new Error('%s appears to be running, but doesn\'t have any 
windows'.format(appIcon.app.get_name()));
         }
 
         this._curApp = -1;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]