[gnome-shell/gnome-3-10] Notification: don't expand the content on a destroyed notification
- From: Giovanni Campagna <gcampagna src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/gnome-3-10] Notification: don't expand the content on a destroyed notification
- Date: Sun, 19 Jan 2014 15:00:59 +0000 (UTC)
commit d981515b08d1c31c1612d5e458874c000128d73d
Author: Giovanni Campagna <gcampagna src gnome org>
Date: Wed Jan 15 18:05:45 2014 +0100
Notification: don't expand the content on a destroyed notification
If the notification is destroyed between an allocate and the redraw,
the meta_later is invoked on a destroyed object, and fails because
the clutter calls are invalid at that point.
https://bugzilla.gnome.org/show_bug.cgi?id=722547
js/ui/messageTray.js | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
---
diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js
index d290a3d..06217d6 100644
--- a/js/ui/messageTray.js
+++ b/js/ui/messageTray.js
@@ -1026,6 +1026,9 @@ const Notification = new Lang.Class({
Meta.later_add(Meta.LaterType.BEFORE_REDRAW,
Lang.bind(this,
function() {
+ if (this._destroyed)
+ return false;
+
if (this._canExpandContent()) {
this._addBannerBody();
this._table.add_style_class_name('multi-line-notification');
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]