[mutter/wayland] cursor-tracker: Rely on gbm_bo_imports()'s buffer validation
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [mutter/wayland] cursor-tracker: Rely on gbm_bo_imports()'s buffer validation
- Date: Thu, 16 Jan 2014 15:48:08 +0000 (UTC)
commit 788bd59857a6b2d56738d01e1d66e270f5f0c80f
Author: Florian Müllner <fmuellner gnome org>
Date: Thu Jan 16 10:10:21 2014 -0500
cursor-tracker: Rely on gbm_bo_imports()'s buffer validation
cogl_texture_get_format() has been deprecated, so rather than using
it to figure out beforehand whether the buffer format is supported,
just rely on the import failing if it isn't.
https://bugzilla.gnome.org/show_bug.cgi?id=722347
src/core/meta-cursor-tracker.c | 45 +++------------------------------------
1 files changed, 4 insertions(+), 41 deletions(-)
---
diff --git a/src/core/meta-cursor-tracker.c b/src/core/meta-cursor-tracker.c
index b3e1b59..a7842f6 100644
--- a/src/core/meta-cursor-tracker.c
+++ b/src/core/meta-cursor-tracker.c
@@ -468,47 +468,10 @@ meta_cursor_reference_from_buffer (MetaCursorTracker *tracker,
if (tracker->gbm)
{
- cogl_format = cogl_texture_get_format (COGL_TEXTURE (self->texture));
- switch (cogl_format)
- {
-#if G_BYTE_ORDER == G_LITTLE_ENDIAN
- case COGL_PIXEL_FORMAT_ARGB_8888_PRE:
- case COGL_PIXEL_FORMAT_ARGB_8888:
- gbm_format = GBM_FORMAT_BGRA8888;
- break;
- case COGL_PIXEL_FORMAT_BGRA_8888_PRE:
- case COGL_PIXEL_FORMAT_BGRA_8888:
- break;
- case COGL_PIXEL_FORMAT_RGB_888:
- break;
-#else
- case COGL_PIXEL_FORMAT_ARGB_8888_PRE:
- case COGL_PIXEL_FORMAT_ARGB_8888:
- gbm_format = GBM_FORMAT_ARGB8888;
- break;
- case COGL_PIXEL_FORMAT_BGRA_8888_PRE:
- case COGL_PIXEL_FORMAT_BGRA_8888:
- gbm_format = GBM_FORMAT_BGRA8888;
- break;
- case COGL_PIXEL_FORMAT_RGB_888:
- gbm_format = GBM_FORMAT_RGB888;
- break;
-#endif
- default:
- meta_warning ("Unknown cogl format %d\n", cogl_format);
- return self;
- }
-
- if (gbm_device_is_format_supported (tracker->gbm, gbm_format,
- GBM_BO_USE_CURSOR_64X64))
- {
- self->bo = gbm_bo_import (tracker->gbm, GBM_BO_IMPORT_WL_BUFFER,
- buffer, GBM_BO_USE_CURSOR_64X64);
- if (!self->bo)
- meta_warning ("Importing HW cursor from wl_buffer failed\n");
- }
- else
- meta_warning ("HW cursor for format %d not supported\n", gbm_format);
+ self->bo = gbm_bo_import (tracker->gbm, GBM_BO_IMPORT_WL_BUFFER,
+ buffer, GBM_BO_USE_CURSOR_64X64);
+ if (!self->bo)
+ meta_warning ("Importing HW cursor from wl_buffer failed\n");
}
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]