[gnome-shell] background: Don't require passing in a background to _updateBackground()



commit 933f38390ba1512aa87c91bd52e9729d2524b6c0
Author: Jasper St. Pierre <jstpierre mecheye net>
Date:   Mon Jan 13 17:12:16 2014 -0500

    background: Don't require passing in a background to _updateBackground()
    
    To make debugging background issues easier.

 js/ui/background.js |   15 +++++++--------
 1 files changed, 7 insertions(+), 8 deletions(-)
---
diff --git a/js/ui/background.js b/js/ui/background.js
index 5eab83a..8d0b5f1 100644
--- a/js/ui/background.js
+++ b/js/ui/background.js
@@ -733,17 +733,17 @@ const BackgroundManager = new Lang.Class({
         }
     },
 
-    _updateBackground: function(background) {
+    _updateBackground: function() {
         let newBackground = this._createBackground();
-        newBackground.vignetteSharpness = background.vignetteSharpness;
-        newBackground.brightness = background.brightness;
-        newBackground.visible = background.visible;
+        newBackground.vignetteSharpness = this.background.vignetteSharpness;
+        newBackground.brightness = this.background.brightness;
+        newBackground.visible = this.background.visible;
 
         newBackground.loadedSignalId = newBackground.connect('loaded',
             Lang.bind(this, function() {
                 newBackground.disconnect(newBackground.loadedSignalId);
                 newBackground.loadedSignalId = 0;
-                Tweener.addTween(background.actor,
+                Tweener.addTween(this.background.actor,
                                  { opacity: 0,
                                    time: FADE_ANIMATION_TIME,
                                    transition: 'easeOutQuad',
@@ -755,8 +755,7 @@ const BackgroundManager = new Lang.Class({
                                            newBackground.actor.destroy();
                                        }
 
-                                       background.actor.destroy();
-
+                                       this.background.actor.destroy();
                                        this.emit('changed');
                                    })
                                  });
@@ -783,7 +782,7 @@ const BackgroundManager = new Lang.Class({
         background.changeSignalId = background.connect('changed', Lang.bind(this, function() {
             background.disconnect(background.changeSignalId);
             background.changeSignalId = 0;
-            this._updateBackground(background);
+            this._updateBackground();
         }));
 
         background.actor.connect('destroy', Lang.bind(this, function() {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]