[bijiben] searchToolbar: do not toggle on arrows, tab, return



commit c0bda4d9bd774c6d84f1b49b4fdd229d495fa940
Author: Pierre-Yves Luyten <py luyten fr>
Date:   Fri Jan 10 22:49:19 2014 +0100

    searchToolbar: do not toggle on arrows, tab, return
    
    Bijiben can be, more or less, keyboard-driven.
    See #720721

 src/bjb-search-toolbar.c |   13 +++++++++++--
 1 files changed, 11 insertions(+), 2 deletions(-)
---
diff --git a/src/bjb-search-toolbar.c b/src/bjb-search-toolbar.c
index 9c19381..cd481ce 100644
--- a/src/bjb-search-toolbar.c
+++ b/src/bjb-search-toolbar.c
@@ -117,7 +117,7 @@ on_key_pressed (GtkWidget *widget,GdkEvent  *event,gpointer user_data)
   if ((event->key.state & modifiers) == GDK_CONTROL_MASK)
     return FALSE;
 
-  /* Reveal the entry is text is input. TODO add more keys not input */
+  /* Reveal the entry is text is input */
   if (gtk_search_bar_get_search_mode (GTK_SEARCH_BAR (self)) == FALSE)
   {
     switch (event->key.keyval)
@@ -128,8 +128,17 @@ on_key_pressed (GtkWidget *widget,GdkEvent  *event,gpointer user_data)
       case GDK_KEY_Shift_R :
       case GDK_KEY_Alt_L :
       case GDK_KEY_Alt_R :
-        return TRUE ;
+      case GDK_KEY_Tab :
+      case GDK_KEY_space :
+      case GDK_KEY_BackSpace :
+      case GDK_KEY_Left :
+      case GDK_KEY_Right :
+      case GDK_KEY_Up :
+      case GDK_KEY_Down :
+      case GDK_KEY_Return :
+        return FALSE;
 
+      /* err, we still return false to get the key for search... */
       default:
         if (event->key.keyval != GDK_KEY_Escape)
           bjb_search_toolbar_fade_in (self);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]