[geary/wip/721570-smtp-auth] A couple of changes to see if one fixes auth problem



commit ac51e864faee94281d2cc356dad1d8ceda49afba
Author: Jim Nelson <jim yorba org>
Date:   Fri Jan 10 12:43:36 2014 -0800

    A couple of changes to see if one fixes auth problem

 src/engine/smtp/smtp-client-session.vala      |    2 ++
 src/engine/smtp/smtp-plain-authenticator.vala |    1 +
 2 files changed, 3 insertions(+), 0 deletions(-)
---
diff --git a/src/engine/smtp/smtp-client-session.vala b/src/engine/smtp/smtp-client-session.vala
index c4144a6..63f8e70 100644
--- a/src/engine/smtp/smtp-client-session.vala
+++ b/src/engine/smtp/smtp-client-session.vala
@@ -107,8 +107,10 @@ public class Geary.Smtp.ClientSession {
             
             // syntax errors indicate the command was unknown or unimplemented, i.e. unavailable
             // authentication type, so try again, otherwise treat as authentication failure
+            /*
             if (!response.code.is_syntax_error())
                 break;
+            */
         } while (auth_order.size > 0);
         
         throw new SmtpError.AUTHENTICATION_FAILED("Unable to authenticate with %s", to_string());
diff --git a/src/engine/smtp/smtp-plain-authenticator.vala b/src/engine/smtp/smtp-plain-authenticator.vala
index d7d13b9..dc6382c 100644
--- a/src/engine/smtp/smtp-plain-authenticator.vala
+++ b/src/engine/smtp/smtp-plain-authenticator.vala
@@ -30,6 +30,7 @@ public class Geary.Smtp.PlainAuthenticator : Geary.Smtp.AbstractAuthenticator {
         growable.append(credentials.user.data);
         growable.append(nul);
         growable.append((credentials.pass ?? "").data);
+        growable.append(nul);
         
         // convert to Base64
         return new Memory.StringBuffer(Base64.encode(growable.get_bytes().get_data()));


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]