[gtk+] GtkMenuTrackerItem: small logic tweak



commit 8256b88eb1201c2d75dba2a88f00b11c7d5b5fee
Author: Ryan Lortie <desrt desrt ca>
Date:   Sat Jan 4 02:04:53 2014 -0500

    GtkMenuTrackerItem: small logic tweak
    
    Strictly speaking, can_activate should always be set back to FALSE when
    the action disappears from the muxer (since we can't activate it
    anymore) but we forgot to do that.
    
    This 'bug' could never cause a problem because 'can_activate' is never
    directly queried for anything at all and the item would get marked
    insensitive anyway.  As soon as the action was re-added, can_activate
    would be recalculated based on the new action before anything else could
    happen.
    
    All the same, this should be cleared here.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=688421

 gtk/gtkmenutrackeritem.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
---
diff --git a/gtk/gtkmenutrackeritem.c b/gtk/gtkmenutrackeritem.c
index d220041..dc46be8 100644
--- a/gtk/gtkmenutrackeritem.c
+++ b/gtk/gtkmenutrackeritem.c
@@ -357,6 +357,8 @@ gtk_menu_tracker_item_action_removed (GtkActionObserver   *observer,
   if (!self->can_activate)
     return;
 
+  self->can_activate = FALSE;
+
   g_object_freeze_notify (G_OBJECT (self));
 
   if (self->sensitive)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]