[epiphany] Fix failed downloads to disconnect from the finished handler
- From: William Jon McCann <mccann src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [epiphany] Fix failed downloads to disconnect from the finished handler
- Date: Tue, 7 Jan 2014 19:52:19 +0000 (UTC)
commit 297c522463fb232ca23c6b1657fb3c2dd5aa526c
Author: Garrett Regier <garrett yorba org>
Date: Wed Jul 3 13:46:05 2013 -0700
Fix failed downloads to disconnect from the finished handler
Otherwise the finished signal will be called right after the failed
handler and the download's label will be set to finished instead
of the error message.
Signed-off-by: Garrett Regier <garrett yorba org>
https://bugzilla.gnome.org/show_bug.cgi?id=703577
lib/widgets/ephy-download-widget.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
---
diff --git a/lib/widgets/ephy-download-widget.c b/lib/widgets/ephy-download-widget.c
index 70ece7c..e9a03c1 100644
--- a/lib/widgets/ephy-download-widget.c
+++ b/lib/widgets/ephy-download-widget.c
@@ -268,12 +268,15 @@ widget_failed_cb (WebKitDownload *download,
{
char *error_msg;
+ g_signal_handlers_disconnect_by_func (download, widget_finished_cb, widget);
g_signal_handlers_disconnect_by_func (download, widget_progress_cb, widget);
error_msg = g_strdup_printf (_("Error downloading: %s"), error->message);
gtk_label_set_text (GTK_LABEL (widget->priv->remaining), error_msg);
gtk_widget_set_tooltip_text (GTK_WIDGET (widget), error_msg);
g_free (error_msg);
+
+ totem_glow_button_set_glow (TOTEM_GLOW_BUTTON (widget->priv->button), TRUE);
}
static void
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]