[gnome-bluetooth] build: Don't override Automake check: target



commit 97659c6f5bc5dd451347b9bee554166d0dac2849
Author: Colin Walters <walters verbum org>
Date:   Thu Jan 2 11:29:21 2014 -0500

    build: Don't override Automake check: target
    
    That causes warnings, which are obvious in the Continuous build view.
    Instead, since the goal of this code is to execute xmllint, use a
    stamp file target.
    
    This fixes the warnings, and furthermore ensures that we only run
    xmllint when the source file changes, instead of on every invocation
    of make.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=721347

 lib/Makefile.am |    9 ++++++---
 1 files changed, 6 insertions(+), 3 deletions(-)
---
diff --git a/lib/Makefile.am b/lib/Makefile.am
index 8067e31..c558d0c 100644
--- a/lib/Makefile.am
+++ b/lib/Makefile.am
@@ -135,12 +135,15 @@ test_pin_LDADD = libgnome-bluetooth.la $(LIBGNOMEBT_LIBS)
 pin_DATA = pin-code-database.xml
 pindir = $(pkgdatadir)
 
-all: check
-
-check:
+pin-code-database.xml.valid: pin-code-database.xml
        @if test -n $(XMLLINT) ; then \
                xmllint --noout --valid $(srcdir)/pin-code-database.xml ;       \
        fi
+       touch $@
+
+CLEANFILES += pin-code-database.xml.valid
+
+all-local: pin-code-database.xml.valid
 
 EXTRA_DIST += bluetooth-client.xml bluetooth-fdo.xml gnome-bluetooth.symbols $(pin_DATA)
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]