[gcr] eggimagemenuitem: Update comments about for GtkImageMenuItem



commit 1317e6dc844ab383a1c5caf55f5eaa0ed5542d54
Author: Stef Walter <stefw gnome org>
Date:   Mon Jan 6 09:54:32 2014 +0100

    eggimagemenuitem: Update comments about for GtkImageMenuItem
    
    Reasoning here: https://docs.google.com/document/d/1KCVPoYQBqMbDP11tHPpjW6uaEHrvLUmcDPqKAppCY8o/pub
    
    Although it would be nice to port to GtkMenuButton, doing so would be
    breaking ABI, and can't be done until 4.x (likely in sync with GTK+ 4.x)
    
    We still want to continue using icons in our dropdown import button.
    So the 'egging' of GtkImageMenuitem still stands.

 ui/eggimagemenuitem.c  |    9 +++++----
 ui/eggimagemenuitem.h  |    9 +++++----
 ui/gcr-import-button.c |    5 +++++
 3 files changed, 15 insertions(+), 8 deletions(-)
---
diff --git a/ui/eggimagemenuitem.c b/ui/eggimagemenuitem.c
index 1e49c7e..6b165c5 100644
--- a/ui/eggimagemenuitem.c
+++ b/ui/eggimagemenuitem.c
@@ -16,10 +16,11 @@
  */
 
 /*
- * EggImageMenuItem was was deprecated from GTK+ without a bug containing
- * reasoning or such. Gcr wants to use image menu items in button drop downs
- * using the device icons (for the import button). So just copy it here :(
- * ... with the stock and activatable sutff removed
+ * GtkImageMenuItem was was deprecated from GTK+ and reasoning explained
+ * here: https://docs.google.com/document/d/1KCVPoYQBqMbDP11tHPpjW6uaEHrvLUmcDPqKAppCY8o/pub
+ * Gcr wants to use image menu items in button drop downs using the device icons
+ * (for the import button). So just copy it here with the stock and activatable
+ * sutff removed
  */
 
 /*
diff --git a/ui/eggimagemenuitem.h b/ui/eggimagemenuitem.h
index bc1cfae..28d26ff 100644
--- a/ui/eggimagemenuitem.h
+++ b/ui/eggimagemenuitem.h
@@ -16,10 +16,11 @@
  */
 
 /*
- * EggImageMenuItem was was deprecated from GTK+ without a bug containing
- * reasoning or such. Gcr wants to use image menu items in button drop downs
- * using the device icons (for the import button). So just copy it here :(
- * ... with the stock and activatable sutff removed
+ * GtkImageMenuItem was was deprecated from GTK+ and reasoning explained
+ * here: https://docs.google.com/document/d/1KCVPoYQBqMbDP11tHPpjW6uaEHrvLUmcDPqKAppCY8o/pub
+ * Gcr wants to use image menu items in button drop downs using the device icons
+ * (for the import button). So just copy it here with the stock and activatable
+ * sutff removed
  */
 
 /*
diff --git a/ui/gcr-import-button.c b/ui/gcr-import-button.c
index 3741340..f218f9f 100644
--- a/ui/gcr-import-button.c
+++ b/ui/gcr-import-button.c
@@ -27,6 +27,7 @@
 #include "gcr/gcr-library.h"
 #include "gcr/gcr-marshal.h"
 #include "gcr/gcr-parser.h"
+#include "gcr/gcr-version.h"
 
 #include "eggimagemenuitem.h"
 #include "gcr-import-button.h"
@@ -88,6 +89,10 @@ static guint signals[LAST_SIGNAL] = { 0 };
 
 static GQuark QUARK_IMPORTER = 0;
 
+#if GCR_CHECK_VERSION(4,0,0)
+#error Port this class to derive from GtkMenuButton during 4.x ABI bump
+#endif
+
 G_DEFINE_TYPE (GcrImportButton, gcr_import_button, GTK_TYPE_BUTTON);
 
 static void


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]