[banshee] AudioCdSource: Log the exception before trying to dispose the ripper



commit 5f5c1d5a57e44a0ab93bd510f47087e3e98f9e63
Author: Bertrand Lorentz <bertrand lorentz gmail com>
Date:   Sun Jan 5 15:57:20 2014 +0100

    AudioCdSource: Log the exception before trying to dispose the ripper
    
    The ripper.Dispose() call can itself cause a crash, which means we would
    not see the original exception in the logs. So we now log the exception
    first.

 .../Banshee.OpticalDisc.AudioCd/AudioCdSource.cs   |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/src/Extensions/Banshee.OpticalDisc/Banshee.OpticalDisc.AudioCd/AudioCdSource.cs 
b/src/Extensions/Banshee.OpticalDisc/Banshee.OpticalDisc.AudioCd/AudioCdSource.cs
index 5c6b52f..5fe1d3f 100644
--- a/src/Extensions/Banshee.OpticalDisc/Banshee.OpticalDisc.AudioCd/AudioCdSource.cs
+++ b/src/Extensions/Banshee.OpticalDisc/Banshee.OpticalDisc.AudioCd/AudioCdSource.cs
@@ -191,12 +191,12 @@ namespace Banshee.OpticalDisc.AudioCd
                     ripper.Start ();
                 }
             } catch (Exception e) {
+                Log.Error (Catalog.GetString ("Could not import CD"), e.Message, true);
+                Log.Exception (e);
+
                 if (ripper != null) {
                     ripper.Dispose ();
                 }
-
-                Log.Error (Catalog.GetString ("Could not import CD"), e.Message, true);
-                Log.Exception (e);
             }
         }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]