[gnome-software] app-tile: Completely remove star ratings
- From: Kalev Lember <klember src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software] app-tile: Completely remove star ratings
- Date: Wed, 26 Feb 2014 17:19:15 +0000 (UTC)
commit 0c78af8729158d39dfb73c1ae3bcff75fe217855
Author: Kalev Lember <kalevlember gmail com>
Date: Wed Feb 26 12:26:01 2014 +0100
app-tile: Completely remove star ratings
Completely rip out star ratings from GsAppTile in order to make more
room for text, until we have a way to automatically generate the needed
data. They were already disabled in commit 044ef3d but still hooked up;
this removes them from the ui file as well.
src/app-tile.ui | 16 ++--------------
src/gs-app-tile.c | 7 -------
2 files changed, 2 insertions(+), 21 deletions(-)
---
diff --git a/src/app-tile.ui b/src/app-tile.ui
index 117580d..b214c05 100644
--- a/src/app-tile.ui
+++ b/src/app-tile.ui
@@ -64,7 +64,7 @@
<property name="left-attach">0</property>
<property name="top-attach">0</property>
<property name="width">1</property>
- <property name="height">3</property>
+ <property name="height">2</property>
</packing>
</child>
<child>
@@ -84,18 +84,6 @@
</packing>
</child>
<child>
- <object class="GsStarWidget" id="stars">
- <property name="visible">False</property>
- <property name="halign">start</property>
- </object>
- <packing>
- <property name="left-attach">1</property>
- <property name="top-attach">1</property>
- <property name="width">1</property>
- <property name="height">1</property>
- </packing>
- </child>
- <child>
<object class="GtkLabel" id="summary">
<property name="visible">True</property>
<property name="ellipsize">end</property>
@@ -104,7 +92,7 @@
</object>
<packing>
<property name="left-attach">1</property>
- <property name="top-attach">2</property>
+ <property name="top-attach">1</property>
<property name="width">1</property>
<property name="height">1</property>
</packing>
diff --git a/src/gs-app-tile.c b/src/gs-app-tile.c
index f41ec5b..a87101d 100644
--- a/src/gs-app-tile.c
+++ b/src/gs-app-tile.c
@@ -25,7 +25,6 @@
#include <gtk/gtk.h>
#include "gs-app-tile.h"
-#include "gs-star-widget.h"
struct _GsAppTilePrivate
{
@@ -36,7 +35,6 @@ struct _GsAppTilePrivate
GtkWidget *summary;
GtkWidget *eventbox;
GtkWidget *waiting;
- GtkWidget *stars;
};
G_DEFINE_TYPE_WITH_PRIVATE (GsAppTile, gs_app_tile, GTK_TYPE_BIN)
@@ -132,9 +130,6 @@ gs_app_tile_set_app (GsAppTile *tile, GsApp *app)
if (!app)
return;
priv->app = g_object_ref (app);
- gs_star_widget_set_rating (GS_STAR_WIDGET (priv->stars),
- gs_app_get_rating_kind (priv->app),
- gs_app_get_rating (priv->app));
gtk_widget_hide (priv->waiting);
@@ -184,7 +179,6 @@ gs_app_tile_init (GsAppTile *tile)
priv = gs_app_tile_get_instance_private (tile);
g_signal_connect_swapped (priv->button, "clicked",
G_CALLBACK (button_clicked), tile);
- gs_star_widget_set_icon_size (GS_STAR_WIDGET (priv->stars), 12);
}
static void
@@ -210,7 +204,6 @@ gs_app_tile_class_init (GsAppTileClass *klass)
gtk_widget_class_bind_template_child_private (widget_class, GsAppTile, summary);
gtk_widget_class_bind_template_child_private (widget_class, GsAppTile, eventbox);
gtk_widget_class_bind_template_child_private (widget_class, GsAppTile, waiting);
- gtk_widget_class_bind_template_child_private (widget_class, GsAppTile, stars);
}
GtkWidget *
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]