[gnumeric] Tests: complain over failures in roundtrip tests...



commit 0be125fa1ccc99beec6f65660fb834dcf50acc2d
Author: Morten Welinder <terra gnome org>
Date:   Wed Feb 19 19:46:42 2014 -0500

    Tests: complain over failures in roundtrip tests...
    
    ...except those we know still do not work.  Let's bring that down to
    a null set soon.

 test/GnumericTest.pm  |    4 ++--
 test/t6500-strings.pl |    3 ++-
 test/t6501-numbers.pl |    9 ++++++---
 test/t6502-styles.pl  |    9 ++++++---
 4 files changed, 16 insertions(+), 9 deletions(-)
---
diff --git a/test/GnumericTest.pm b/test/GnumericTest.pm
index e540ccb..f4a8fb0 100644
--- a/test/GnumericTest.pm
+++ b/test/GnumericTest.pm
@@ -362,6 +362,7 @@ sub test_roundtrip {
     my $format = $named_args{'format'};
     my $newext = $named_args{'ext'};
     my $resize = $named_args{'resize'};
+    my $ignore_failure = $named_args{'ignore_failure'};
 
     my $filter1 = $named_args{'filter1'} || $named_args{'filter'} || 'cat';
     my $filter2 = $named_args{'filter2'} || $named_args{'filter'} || 'cat';
@@ -401,8 +402,7 @@ sub test_roundtrip {
     &system_failure ('zcat', $code) if $code;
 
     $code = system ('diff', '-u', $tmp_xml, $tmp2_xml);
-    # Ignore failures for now.
-    # &system_failure ('diff', $code) if $code;
+    &system_failure ('diff', $code) if $code && !$ignore_failure;
 
     print STDERR "Pass\n";
 }
diff --git a/test/t6500-strings.pl b/test/t6500-strings.pl
index ebc0150..adce22e 100755
--- a/test/t6500-strings.pl
+++ b/test/t6500-strings.pl
@@ -37,4 +37,5 @@ my $xls_filter = "$PERL -p -e '\$_ = \"\" if m{<meta:user-defined meta:name=.mso
 &test_roundtrip ($file,
                 'format' => 'Gnumeric_Excel:xlsx',
                 'ext' => "xlsx",
-                'resize' => '1048576x16384');
+                'resize' => '1048576x16384',
+                'ignore_failure' => 1);
diff --git a/test/t6501-numbers.pl b/test/t6501-numbers.pl
index dccbcfc..7c3949b 100755
--- a/test/t6501-numbers.pl
+++ b/test/t6501-numbers.pl
@@ -28,16 +28,19 @@ my $xls_filter = "$PERL -p -e '\$_ = \"\" if m{<meta:user-defined meta:name=.mso
                 'format' => 'Gnumeric_Excel:excel_biff7',
                 'ext' => "xls",
                 'resize' => '16384x256',
-                'filter2' => $xls_filter);
+                'filter2' => $xls_filter,
+                'ignore_failure' => 1);
 
 &message ("Check number xls/BIFF8 roundtrip.");
 &test_roundtrip ($file,
                 'format' => 'Gnumeric_Excel:excel_biff8',
                 'ext' => "xls",
-                'filter2' => $xls_filter);
+                'filter2' => $xls_filter,
+                'ignore_failure' => 1);
 
 &message ("Check number xlsx roundtrip.");
 &test_roundtrip ($file,
                 'format' => 'Gnumeric_Excel:xlsx',
                 'ext' => "xlsx",
-                'resize' => '1048576x16384');
+                'resize' => '1048576x16384',
+                'ignore_failure' => 1);
diff --git a/test/t6502-styles.pl b/test/t6502-styles.pl
index 7a330d3..3392958 100755
--- a/test/t6502-styles.pl
+++ b/test/t6502-styles.pl
@@ -25,16 +25,19 @@ my $xls_filter = "$PERL -p -e '\$_ = \"\" if m{<meta:user-defined meta:name=.mso
                 'format' => 'Gnumeric_Excel:excel_biff7',
                 'ext' => "xls",
                 'resize' => '16384x256',
-                'filter2' => $xls_filter);
+                'filter2' => $xls_filter,
+                'ignore_failure' => 1);
 
 &message ("Check style xls/BIFF8 roundtrip.");
 &test_roundtrip ($file,
                 'format' => 'Gnumeric_Excel:excel_biff8',
                 'ext' => "xls",
-                'filter2' => $xls_filter);
+                'filter2' => $xls_filter,
+                'ignore_failure' => 1);
 
 &message ("Check style xlsx roundtrip.");
 &test_roundtrip ($file,
                 'format' => 'Gnumeric_Excel:xlsx',
                 'ext' => "xlsx",
-                'resize' => '1048576x16384');
+                'resize' => '1048576x16384',
+                'ignore_failure' => 1);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]