[gnome-sound-recorder] preferences.js: make changes to improve appearance
- From: Meg Ford (Margaret) <megford src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-sound-recorder] preferences.js: make changes to improve appearance
- Date: Wed, 19 Feb 2014 22:31:07 +0000 (UTC)
commit a1b6865823b6bd54eb97bcda2a8312447e5f88dd
Author: Meg Ford <meg387 gmail com>
Date: Wed Feb 19 13:15:05 2014 -0600
preferences.js: make changes to improve appearance
See bug https://bugzilla.gnome.org/show_bug.cgi?id=724675
src/info.js | 4 +-
src/preferences.js | 65 ++++++++++++++++++++++++++++++---------------------
2 files changed, 40 insertions(+), 29 deletions(-)
---
diff --git a/src/info.js b/src/info.js
index 92a17a0..a88f04a 100644
--- a/src/info.js
+++ b/src/info.js
@@ -37,11 +37,11 @@ const InfoDialog = new Lang.Class({
this._file = Gio.File.new_for_uri(fileNav.uri);
- this.widget = new Gtk.Dialog ({ resizable: false,
+ this.widget = new Gtk.Dialog ({ title: _("Info"),
+ resizable: false,
modal: true,
destroy_with_parent: true,
default_width: 400,
- title: _("Info"),
hexpand: true });
this.widget.set_transient_for(Gio.Application.get_default().get_active_window());
let header = new Gtk.HeaderBar({ hexpand: true });
diff --git a/src/preferences.js b/src/preferences.js
index 9df7ee4..625b713 100644
--- a/src/preferences.js
+++ b/src/preferences.js
@@ -39,39 +39,50 @@ const Preferences = new Lang.Class({
resizable: false,
modal: true,
destroy_with_parent: true,
- width_request: 350,
+ default_width: 400,
margin_top: 5,
hexpand: true });
this.widget.set_transient_for(Gio.Application.get_default().get_active_window());
- this.widget.add_button(_("Done"), Gtk.ResponseType.OK);
+ let header = new Gtk.HeaderBar({ hexpand: true });
+ header.set_show_close_button(false);
+ this.widget.set_titlebar(header);
- let mainGrid = new Gtk.Grid({ orientation: Gtk.Orientation.VERTICAL,
- row_spacing: 6,
- margin_left: 12,
- margin_right: 12 });
+ let buttonToolbar = new Gtk.Box({ orientation: Gtk.Orientation.HORIZONTAL,
+ spacing: 0 });
+ buttonToolbar.get_style_context().add_class(Gtk.STYLE_CLASS_LINKED);
+ header.pack_end(buttonToolbar);
+
+ let button = new Gtk.Button({ label: _("Done") });
+ button.connect("clicked", Lang.bind(this, this.onDoneClicked));
+ buttonToolbar.pack_end(button, false, true, 0);
+ button.show();
+ buttonToolbar.show();
+
+ let grid = new Gtk.Grid ({ orientation: Gtk.Orientation.VERTICAL,
+ row_homogeneous: true,
+ column_homogeneous: true,
+ halign: Gtk.Align.CENTER,
+ row_spacing: 6,
+ column_spacing: 24,
+ margin_top: 12,
+ margin_left: 24,
+ margin_right: 24,
+ margin_bottom: 12 });
let contentArea = this.widget.get_content_area();
- contentArea.pack_start(mainGrid, true, true, 0);
-
- let grid = new Gtk.Grid({ orientation: Gtk.Orientation.VERTICAL,
- hexpand: true,
- vexpand: true,
- column_spacing: 18,
- row_spacing: 6 });
- mainGrid.add(grid);
-
+ contentArea.pack_start(grid, true, true, 2);
- let formatLabel = new Gtk.Label({ label: '<b>' + _("Preferred format") + '</b>',
- halign: Gtk.Align.START,
- use_markup: true });
- grid.attach(formatLabel, 0, 0, 1, 1);
+ let formatLabel = new Gtk.Label({ label: _("Preferred format"),
+ halign: Gtk.Align.END });
+ formatLabel.get_style_context ().add_class('dim-label');
+ grid.attach(formatLabel, 0, 0, 2, 1);
comboBoxText = new MainWindow.EncoderComboBox({ halign: Gtk.Align.END });
- grid.attach(comboBoxText, 2, 0, 1, 1);
+ grid.attach(comboBoxText, 2, 0, 2, 1);
- let volumeLabel = new Gtk.Label({ label: '<b>' + _("Volume") + '</b>',
- halign: Gtk.Align.START,
- use_markup: true });
+ let volumeLabel = new Gtk.Label({ label: _("Volume"),
+ halign: Gtk.Align.END });
+ volumeLabel.get_style_context ().add_class('dim-label');
grid.attach(volumeLabel, 0, 1, 2, 1);
playVolume = new Gtk.Scale({ orientation: Gtk.Orientation.HORIZONTAL });
@@ -84,9 +95,9 @@ const Preferences = new Lang.Class({
}));
grid.attach(playVolume, 2, 1, 2, 1);
- let micVolLabel = new Gtk.Label({ label: '<b>' + _("Microphone") + '</b>',
- halign: Gtk.Align.START,
- use_markup: true });
+ let micVolLabel = new Gtk.Label({ label: _("Microphone"),
+ halign: Gtk.Align.END });
+ micVolLabel.get_style_context ().add_class('dim-label');
grid.attach(micVolLabel, 0, 2, 2, 1);
recordVolume = new Gtk.Scale({ orientation: Gtk.Orientation.HORIZONTAL });
@@ -104,5 +115,5 @@ const Preferences = new Lang.Class({
onDoneClicked: function() {
this.widget.destroy();
- }
+ }
});
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]