[gnome-shell] NetworkMenu: sort connections by name only
- From: Giovanni Campagna <gcampagna src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] NetworkMenu: sort connections by name only
- Date: Mon, 17 Feb 2014 19:45:17 +0000 (UTC)
commit 2bb3aed72982970a39749db0c7a095dafb04cdf4
Author: Giovanni Campagna <gcampagna src gnome org>
Date: Sat Feb 8 14:33:32 2014 +0100
NetworkMenu: sort connections by name only
We don't watch for timestamp changes, and sorting by name keeps
the order consistent and predictable. In practice, there should
be at most 3 or 4 elements, so the user will always read all them
at once and sorting is irrelevant.
https://bugzilla.gnome.org/show_bug.cgi?id=723570
js/ui/status/network.js | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
---
diff --git a/js/ui/status/network.js b/js/ui/status/network.js
index 5e9d478..ff536d0 100644
--- a/js/ui/status/network.js
+++ b/js/ui/status/network.js
@@ -249,10 +249,7 @@ const NMConnectionSection = new Lang.Class({
},
_connectionSortFunction: function(one, two) {
- if (one._timestamp == two._timestamp)
- return GLib.utf8_collate(one.get_id(), two.get_id());
-
- return two._timestamp - one._timestamp;
+ return GLib.utf8_collate(one.get_id(), two.get_id());
},
_makeConnectionItem: function(connection) {
@@ -1788,7 +1785,6 @@ const NMApplet = new Lang.Class({
let connectionSettings =
connection.get_setting_by_name(NetworkManager.SETTING_CONNECTION_SETTING_NAME);
connection._type = connectionSettings.type;
connection._section = this._ctypes[connection._type] || NMConnectionCategory.INVALID;
- connection._timestamp = connectionSettings.timestamp;
let section = connection._section;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]