[easytag/wip/application-window] Remove bogus comparison in Id3tag_Read_File_Tag



commit 14fb7ac92cece1e76453b054e48e268275764ddb
Author: David King <amigadave amigadave com>
Date:   Sat Feb 15 23:18:38 2014 +0000

    Remove bogus comparison in Id3tag_Read_File_Tag
    
    Found with cppcheck.

 src/id3v24_tag.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/src/id3v24_tag.c b/src/id3v24_tag.c
index 5d7bbcd..52b079e 100644
--- a/src/id3v24_tag.c
+++ b/src/id3v24_tag.c
@@ -307,7 +307,7 @@ gboolean Id3tag_Read_File_Tag (const gchar *filename, File_Tag *FileTag)
             unsigned genre = 0;
             FileTag->genre = NULL;
 
-            if ( (string1[0]=='(') && (tmp=strchr(string1,')')) && (tmp+1) && (strlen((tmp+1))>0) )
+            if ((string1[0] == '(') && (tmp = strchr (string1,')')) && *(tmp+1))
                 /* Convert a genre written as '(3)EuroDance' into 'EuroDance' */
             {
                 FileTag->genre = g_strdup(tmp+1);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]