[gnome-boxes] properties: Remove 'Reboot required' infobar



commit e0ecca3933d3e1c6699149e4d52120a12fcee8a6
Author: Zeeshan Ali (Khattak) <zeeshanak gnome org>
Date:   Tue Feb 11 13:27:10 2014 +0000

    properties: Remove 'Reboot required' infobar
    
    This infobar is redundant and looks ugly. We do present a notification
    that says basically the same thing and it even offers a button to
    actually restart the machine.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=710300

 src/properties.vala |   31 -------------------------------
 1 files changed, 0 insertions(+), 31 deletions(-)
---
diff --git a/src/properties.vala b/src/properties.vala
index f899485..434a332 100644
--- a/src/properties.vala
+++ b/src/properties.vala
@@ -22,28 +22,10 @@ private class Boxes.Properties: Gtk.Notebook, Boxes.UI {
     private class PageWidget: Gtk.Grid {
         public bool empty;
 
-        private Gtk.InfoBar infobar;
         private List<Boxes.Property> properties;
 
         public signal void refresh_properties ();
 
-        public void update_infobar () {
-            var show_it = false;
-            foreach (var property in properties) {
-                if (property.reboot_required) {
-                    show_it = true;
-                    break;
-                }
-            }
-            infobar.visible = show_it;
-        }
-
-        ~PageWidget () {
-            foreach (var property in properties) {
-                SignalHandler.disconnect_by_func (property, (void*)update_infobar, this);
-            }
-        }
-
         public PageWidget (PropertiesPage page, Machine machine) {
             switch (page) {
             case PropertiesPage.LOGIN:
@@ -68,16 +50,6 @@ private class Boxes.Properties: Gtk.Notebook, Boxes.UI {
             column_spacing = 20;
             valign = Gtk.Align.START;
 
-            infobar = new Gtk.InfoBar ();
-            infobar.no_show_all = true;
-            var infobar_container = infobar.get_content_area () as Gtk.Container;
-            var label = new Gtk.Label (_("Some changes may take effect only after reboot"));
-            label.visible = true;
-            infobar_container.add (label);
-            infobar.message_type = Gtk.MessageType.INFO;
-            infobar.hexpand = true;
-            attach (infobar, 0, 0, 2, 1);
-
             PropertyCreationFlag flags = PropertyCreationFlag.NONE;
             properties = machine.get_properties (page, ref flags);
             empty = properties.length () == 0;
@@ -109,14 +81,11 @@ private class Boxes.Properties: Gtk.Notebook, Boxes.UI {
                         attach (widget, 0, current_row, 2, 1);
                     }
 
-                    property.notify["reboot-required"].connect (update_infobar);
                     property.refresh_properties.connect (() => {
                         this.refresh_properties ();
                      });
                     current_row += 1;
                 }
-
-                update_infobar ();
             }
 
             show_all ();


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]