[gnome-software] Don't show such a big gap on the details page if there are no screenshots



commit 61a036e44fd8241177666d645be01d794740a0af
Author: Richard Hughes <richard hughsie com>
Date:   Fri Feb 7 21:16:22 2014 +0100

    Don't show such a big gap on the details page if there are no screenshots

 src/gnome-software.ui  |    3 ++-
 src/gs-shell-details.c |    3 +++
 2 files changed, 5 insertions(+), 1 deletions(-)
---
diff --git a/src/gnome-software.ui b/src/gnome-software.ui
index 73a6905..94138e7 100644
--- a/src/gnome-software.ui
+++ b/src/gnome-software.ui
@@ -1256,6 +1256,7 @@
                                 <property name="visible">True</property>
                                 <property name="can_focus">False</property>
                                 <property name="spacing">9</property>
+                                <property name="margin_bottom">32</property>
                                 <child>
                                   <object class="GtkBox" id="box_details_screenshot_main">
                                     <property name="visible">True</property>
@@ -1297,7 +1298,7 @@
                             </child>
                             <child>
                               <object class="GtkBox" id="box_details_description">
-                                <property name="margin_top">64</property>
+                                <property name="margin_top">32</property>
                                 <property name="visible">True</property>
                                 <property name="can_focus">False</property>
                                 <property name="orientation">vertical</property>
diff --git a/src/gs-shell-details.c b/src/gs-shell-details.c
index 7485ca4..67266c1 100644
--- a/src/gs-shell-details.c
+++ b/src/gs-shell-details.c
@@ -348,6 +348,9 @@ gs_shell_details_refresh_screenshots (GsShellDetails *shell_details)
                                                     "box_details_screenshot_main"));
        gs_container_remove_all (GTK_CONTAINER (widget));
        screenshots = gs_app_get_screenshots (priv->app);
+       widget = GTK_WIDGET (gtk_builder_get_object (priv->builder,
+                                                    "box_details_screenshot"));
+       gtk_widget_set_visible (widget, screenshots->len > 0);
        if (screenshots->len == 0) {
                widget = GTK_WIDGET (gtk_builder_get_object (priv->builder,
                                                             "box_details_screenshot_thumbnails"));


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]