[easytag/easytag-2-2] Fix stripping disc number field from ID3v2.4 tags
- From: David King <davidk src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [easytag/easytag-2-2] Fix stripping disc number field from ID3v2.4 tags
- Date: Mon, 29 Dec 2014 11:49:02 +0000 (UTC)
commit 660b3f93a64c64330517a5fc060df07760f6a5c7
Author: David King <amigadave amigadave com>
Date: Mon Dec 29 11:43:02 2014 +0000
Fix stripping disc number field from ID3v2.4 tags
As part of a change made in bug 726467, disc number handling for ID3
tags was modified to only allow digits and the '/' character in the TPOS
field. A bogus check was added for ID3 tags, so that if saving a tag
with no content in the disc number field, the existing TPOS tag would
not be cleared.
Remove the erroneous check, as et_id3tag_get_tpos_from_file_tag() safely
handles the disc number field being empty.
https://bugzilla.gnome.org/show_bug.cgi?id=742082
src/id3v24_tag.c | 11 ++++-------
1 files changed, 4 insertions(+), 7 deletions(-)
---
diff --git a/src/id3v24_tag.c b/src/id3v24_tag.c
index a25167c..ef073fb 100644
--- a/src/id3v24_tag.c
+++ b/src/id3v24_tag.c
@@ -959,13 +959,10 @@ gboolean Id3tag_Write_File_v24Tag (ET_File *ETFile)
/***************
* Part of set *
***************/
- if (FileTag->disc_number)
- {
- string1 = et_id3tag_get_tpos_from_file_tag (FileTag);
- etag_set_tags (string1, "TPOS", ID3_FIELD_TYPE_STRINGLIST, NULL, v2tag,
- &strip_tags);
- g_free (string1);
- }
+ string1 = et_id3tag_get_tpos_from_file_tag (FileTag);
+ etag_set_tags (string1, "TPOS", ID3_FIELD_TYPE_STRINGLIST, NULL, v2tag,
+ &strip_tags);
+ g_free (string1);
/********
* Year *
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]