GNOME.org
 

[rhythmbox] Remove _BSD_SOURCE from makefiles

commit f624b41b8032c3ab82075d4ed18048dda026a323
Author: Jonathan Matthew <jonathan d14n org>
Date:   Tue Dec 23 10:22:50 2014 +1000

    Remove _BSD_SOURCE from makefiles
    
    This appears to have crept in with something relating to dashboard
    (who even remembers dashboard?) about 10 years ago.  glibc headers
    have recently started complaining about it, so it's time for it to go.

 plugins/audiocd/Makefile.am               |    4 +---
 plugins/audioscrobbler/Makefile.am        |    3 +--
 plugins/brasero-disc-recorder/Makefile.am |    1 -
 plugins/daap/Makefile.am                  |    3 +--
 plugins/dbus-media-server/Makefile.am     |    1 -
 plugins/fmradio/Makefile.am               |    3 +--
 plugins/generic-player/Makefile.am        |    3 +--
 plugins/grilo/Makefile.am                 |    3 +--
 plugins/ipod/Makefile.am                  |    3 +--
 plugins/iradio/Makefile.am                |    3 +--
 plugins/lirc/Makefile.am                  |    3 +--
 plugins/mmkeys/Makefile.am                |    1 -
 plugins/mpris/Makefile.am                 |    1 -
 plugins/mtpdevice/Makefile.am             |    3 +--
 plugins/notification/Makefile.am          |    3 +--
 plugins/power-manager/Makefile.am         |    3 +--
 plugins/visualizer/Makefile.am            |    3 +--
 remote/dbus/Makefile.am                   |    2 +-
 sample-plugins/sample-vala/Makefile.am    |    3 +--
 sample-plugins/sample/Makefile.am         |    3 +--
 shell/Makefile.am                         |    2 +-
 tests/Makefile.am                         |    3 +--
 22 files changed, 18 insertions(+), 39 deletions(-)
---
diff --git a/plugins/audiocd/Makefile.am b/plugins/audiocd/Makefile.am
index d6d35ce..87cf6e2 100644
--- a/plugins/audiocd/Makefile.am
+++ b/plugins/audiocd/Makefile.am
@@ -37,9 +37,7 @@ INCLUDES =                                            \
        -DSHARE_DIR=\"$(pkgdatadir)\"                   \
        -DDATADIR=\""$(datadir)"\"                      \
        $(TOTEM_PLPARSER_CFLAGS)                        \
-       $(RHYTHMBOX_CFLAGS)                             \
-       -DUSE_TOTEM_PL_PARSER                           \
-       -D_BSD_SOURCE
+       $(RHYTHMBOX_CFLAGS)
 
 libaudiocd_la_LIBADD += $(NULL)
 
diff --git a/plugins/audioscrobbler/Makefile.am b/plugins/audioscrobbler/Makefile.am
index a79f30b..811e163 100644
--- a/plugins/audioscrobbler/Makefile.am
+++ b/plugins/audioscrobbler/Makefile.am
@@ -52,8 +52,7 @@ INCLUDES =                                            \
        -DDATADIR=\""$(datadir)"\"                      \
        $(TOTEM_PLPARSER_CFLAGS)                        \
        $(JSON_GLIB_CFLAGS)                             \
-       $(RHYTHMBOX_CFLAGS)                             \
-       -D_BSD_SOURCE
+       $(RHYTHMBOX_CFLAGS)
 
 gtkbuilderdir = $(plugindatadir)
 gtkbuilder_DATA =                                      \
diff --git a/plugins/brasero-disc-recorder/Makefile.am b/plugins/brasero-disc-recorder/Makefile.am
index 678b1c5..8e4eb70 100644
--- a/plugins/brasero-disc-recorder/Makefile.am
+++ b/plugins/brasero-disc-recorder/Makefile.am
@@ -30,7 +30,6 @@ INCLUDES =                                            \
        -DDATADIR=\""$(datadir)"\"                      \
        $(RHYTHMBOX_CFLAGS)                             \
        $(LIBBRASERO_MEDIA_CFLAGS)                      \
-       -D_BSD_SOURCE                   \
        $(NULL)
 
 plugin_in_files = cd-recorder.plugin.in
diff --git a/plugins/daap/Makefile.am b/plugins/daap/Makefile.am
index f4bb907..1bdd31c 100644
--- a/plugins/daap/Makefile.am
+++ b/plugins/daap/Makefile.am
@@ -60,8 +60,7 @@ INCLUDES =                                            \
        -DSHARE_DIR=\"$(pkgdatadir)\"                   \
        -DDATADIR=\""$(datadir)"\"                      \
        $(DMAPSHARING_CFLAGS)                           \
-       $(RHYTHMBOX_CFLAGS)                             \
-       -D_BSD_SOURCE
+       $(RHYTHMBOX_CFLAGS)
 
 if USE_LIBSECRET
 libdaap_la_LIBADD += $(LIBSECRET_LIBS)
diff --git a/plugins/dbus-media-server/Makefile.am b/plugins/dbus-media-server/Makefile.am
index 3364ed6..87fb7e3 100644
--- a/plugins/dbus-media-server/Makefile.am
+++ b/plugins/dbus-media-server/Makefile.am
@@ -24,7 +24,6 @@ INCLUDES =                                            \
        -DSHARE_DIR=\"$(pkgdatadir)\"                   \
        -DDATADIR=\""$(datadir)"\"                      \
        $(RHYTHMBOX_CFLAGS)                             \
-       -D_BSD_SOURCE                   \
        $(NULL)
 
 plugin_in_files = dbus-media-server.plugin.in
diff --git a/plugins/fmradio/Makefile.am b/plugins/fmradio/Makefile.am
index c028953..195523a 100644
--- a/plugins/fmradio/Makefile.am
+++ b/plugins/fmradio/Makefile.am
@@ -32,8 +32,7 @@ INCLUDES = \
   -DDATADIR=\""$(datadir)"\" \
   $(RHYTHMBOX_CFLAGS) \
   $(TOTEM_PLPARSER_CFLAGS) \
-  $(WARN_CFLAGS) \
-  -D_BSD_SOURCE
+  $(WARN_CFLAGS)
 
 plugin_in_files = fmradio.plugin.in
 %.plugin: %.plugin.in $(INTLTOOL_MERGE) $(wildcard $(top_srcdir)/po/*po) ; $(INTLTOOL_MERGE) 
$(top_srcdir)/po $< $@ -d -u -c $(top_builddir)/po/.intltool-merge-cache
diff --git a/plugins/generic-player/Makefile.am b/plugins/generic-player/Makefile.am
index 02dbad3..b73018b 100644
--- a/plugins/generic-player/Makefile.am
+++ b/plugins/generic-player/Makefile.am
@@ -37,8 +37,7 @@ INCLUDES =                                            \
        -DSHARE_DIR=\"$(pkgdatadir)\"                   \
        -DDATADIR=\""$(datadir)"\"                      \
        $(TOTEM_PLPARSER_CFLAGS)                        \
-       $(RHYTHMBOX_CFLAGS)                             \
-       -D_BSD_SOURCE
+       $(RHYTHMBOX_CFLAGS)
 
 gtkbuilderdir = $(plugindatadir)
 gtkbuilder_DATA = generic-player-info.ui generic-player-toolbar.ui
diff --git a/plugins/grilo/Makefile.am b/plugins/grilo/Makefile.am
index 2776eba..ca00506 100644
--- a/plugins/grilo/Makefile.am
+++ b/plugins/grilo/Makefile.am
@@ -29,8 +29,7 @@ INCLUDES =                                            \
        -DSHARE_DIR=\"$(pkgdatadir)\"                   \
        -DDATADIR=\""$(datadir)"\"                      \
        $(RHYTHMBOX_CFLAGS)                             \
-       $(GRILO_CFLAGS)                                 \
-       -D_BSD_SOURCE
+       $(GRILO_CFLAGS)
 
 libgrilo_la_LIBADD += $(NULL)
 
diff --git a/plugins/ipod/Makefile.am b/plugins/ipod/Makefile.am
index cc0eef3..ef699da 100644
--- a/plugins/ipod/Makefile.am
+++ b/plugins/ipod/Makefile.am
@@ -37,8 +37,7 @@ INCLUDES =                                            \
        -DSHARE_DIR=\"$(pkgdatadir)\"                   \
        -DDATADIR=\""$(datadir)"\"                      \
        $(RHYTHMBOX_CFLAGS)                             \
-       $(IPOD_CFLAGS)                                  \
-       -D_BSD_SOURCE
+       $(IPOD_CFLAGS)
 
 plugin_in_files = ipod.plugin.in
 
diff --git a/plugins/iradio/Makefile.am b/plugins/iradio/Makefile.am
index 8c67130..eaad432 100644
--- a/plugins/iradio/Makefile.am
+++ b/plugins/iradio/Makefile.am
@@ -36,8 +36,7 @@ INCLUDES =                                            \
        -DSHARE_DIR=\"$(pkgdatadir)\"                   \
        -DDATADIR=\""$(datadir)"\"                      \
        $(RHYTHMBOX_CFLAGS)                             \
-       $(TOTEM_PLPARSER_CFLAGS)                        \
-       -D_BSD_SOURCE
+       $(TOTEM_PLPARSER_CFLAGS)
 
 gtkbuilderdir = $(plugindatadir)
 gtkbuilder_DATA =                                      \
diff --git a/plugins/lirc/Makefile.am b/plugins/lirc/Makefile.am
index 74cab23..a06bf2c 100644
--- a/plugins/lirc/Makefile.am
+++ b/plugins/lirc/Makefile.am
@@ -27,8 +27,7 @@ INCLUDES =                                            \
        -DPIXMAP_DIR=\""$(datadir)/pixmaps"\"           \
        -DSHARE_DIR=\"$(pkgdatadir)\"                   \
        -DDATADIR=\""$(datadir)"\"                      \
-       $(RHYTHMBOX_CFLAGS)                             \
-       -D_BSD_SOURCE
+       $(RHYTHMBOX_CFLAGS)
 
 plugin_in_files = rblirc.plugin.in
 
diff --git a/plugins/mmkeys/Makefile.am b/plugins/mmkeys/Makefile.am
index c0102ae..e747857 100644
--- a/plugins/mmkeys/Makefile.am
+++ b/plugins/mmkeys/Makefile.am
@@ -30,7 +30,6 @@ INCLUDES =                                            \
        -DSHARE_DIR=\"$(pkgdatadir)\"                   \
        -DDATADIR=\""$(datadir)"\"                      \
        $(RHYTHMBOX_CFLAGS)                             \
-       -D_BSD_SOURCE                   \
        $(NULL)
 
 plugin_in_files = mmkeys.plugin.in
diff --git a/plugins/mpris/Makefile.am b/plugins/mpris/Makefile.am
index 409df19..0789463 100644
--- a/plugins/mpris/Makefile.am
+++ b/plugins/mpris/Makefile.am
@@ -24,7 +24,6 @@ INCLUDES =                                            \
        -DSHARE_DIR=\"$(pkgdatadir)\"                   \
        -DDATADIR=\""$(datadir)"\"                      \
        $(RHYTHMBOX_CFLAGS)                             \
-       -D_BSD_SOURCE                   \
        $(NULL)
 
 plugin_in_files = mpris.plugin.in
diff --git a/plugins/mtpdevice/Makefile.am b/plugins/mtpdevice/Makefile.am
index 3afc995..7439032 100644
--- a/plugins/mtpdevice/Makefile.am
+++ b/plugins/mtpdevice/Makefile.am
@@ -44,8 +44,7 @@ INCLUDES =                                            \
        $(RHYTHMBOX_CFLAGS)                             \
        $(GUDEV_CFLAGS)                                 \
        $(HAL_CFLAGS)                                   \
-       $(MTP_CFLAGS)                                   \
-       -D_BSD_SOURCE
+       $(MTP_CFLAGS)
 
 plugin_in_files = mtpdevice.plugin.in
 
diff --git a/plugins/notification/Makefile.am b/plugins/notification/Makefile.am
index f6c3db1..7d4f603 100644
--- a/plugins/notification/Makefile.am
+++ b/plugins/notification/Makefile.am
@@ -30,8 +30,7 @@ INCLUDES =                                            \
        -DSHARE_DIR=\"$(pkgdatadir)\"                   \
        -DDATADIR=\""$(datadir)"\"                      \
        $(RHYTHMBOX_CFLAGS)                             \
-       $(NOTIFY_CFLAGS)                                \
-       -D_BSD_SOURCE
+       $(NOTIFY_CFLAGS)
 
 plugin_in_files = notification.plugin.in
 
diff --git a/plugins/power-manager/Makefile.am b/plugins/power-manager/Makefile.am
index f436e12..8876500 100644
--- a/plugins/power-manager/Makefile.am
+++ b/plugins/power-manager/Makefile.am
@@ -26,8 +26,7 @@ INCLUDES =                                            \
        -DPIXMAP_DIR=\""$(datadir)/pixmaps"\"           \
        -DSHARE_DIR=\"$(pkgdatadir)\"                   \
        -DDATADIR=\""$(datadir)"\"                      \
-       $(RHYTHMBOX_CFLAGS)                             \
-       -D_BSD_SOURCE
+       $(RHYTHMBOX_CFLAGS)
 
 plugin_in_files = power-manager.plugin.in
 
diff --git a/plugins/visualizer/Makefile.am b/plugins/visualizer/Makefile.am
index 800a092..70b22bc 100644
--- a/plugins/visualizer/Makefile.am
+++ b/plugins/visualizer/Makefile.am
@@ -32,8 +32,7 @@ INCLUDES =                                            \
        -DDATADIR=\""$(datadir)"\"                      \
        -DPLUGIN_SRC_DIR=\""$(ROOT_UNINSTALLED_DIR)/plugins/visualizer"\" \
        $(RHYTHMBOX_CFLAGS)                             \
-       $(CLUTTER_CFLAGS)                                       \
-       -D_BSD_SOURCE
+       $(CLUTTER_CFLAGS)
 
 mxthemedir = $(plugindatadir)
 mxtheme_DATA =                                                 \
diff --git a/remote/dbus/Makefile.am b/remote/dbus/Makefile.am
index 12e80c4..77c0381 100644
--- a/remote/dbus/Makefile.am
+++ b/remote/dbus/Makefile.am
@@ -17,7 +17,7 @@ INCLUDES =                                            \
        -DDATADIR=\""$(datadir)"\"                      \
        $(RHYTHMBOX_CFLAGS)                             \
        $(DBUS_CFLAGS)                                  \
-       -D__EXTENSIONS__ -D_BSD_SOURCE
+       -D__EXTENSIONS__
 
 EXTRA_DIST = rb-client.c rb-print-playing.py rb-set-rating.py
 
diff --git a/sample-plugins/sample-vala/Makefile.am b/sample-plugins/sample-vala/Makefile.am
index 9d3631e..1fd4720 100644
--- a/sample-plugins/sample-vala/Makefile.am
+++ b/sample-plugins/sample-vala/Makefile.am
@@ -26,8 +26,7 @@ INCLUDES =                                            \
        -DPIXMAP_DIR=\""$(datadir)/pixmaps"\"           \
        -DSHARE_DIR=\"$(pkgdatadir)\"                   \
        -DDATADIR=\""$(datadir)"\"                      \
-       $(RHYTHMBOX_CFLAGS)                             \
-       -D_BSD_SOURCE
+       $(RHYTHMBOX_CFLAGS)
 
 
 plugin_in_files = sample-vala.plugin.in
diff --git a/sample-plugins/sample/Makefile.am b/sample-plugins/sample/Makefile.am
index dc55684..67860dd 100644
--- a/sample-plugins/sample/Makefile.am
+++ b/sample-plugins/sample/Makefile.am
@@ -23,8 +23,7 @@ INCLUDES =                                            \
        -DPIXMAP_DIR=\""$(datadir)/pixmaps"\"           \
        -DSHARE_DIR=\"$(pkgdatadir)\"                   \
        -DDATADIR=\""$(datadir)"\"                      \
-       $(RHYTHMBOX_CFLAGS)                             \
-       -D_BSD_SOURCE
+       $(RHYTHMBOX_CFLAGS)
 
 plugin_in_files = sample.plugin.in
 
diff --git a/shell/Makefile.am b/shell/Makefile.am
index 65a702d..c211201 100644
--- a/shell/Makefile.am
+++ b/shell/Makefile.am
@@ -47,7 +47,7 @@ INCLUDES =                                            \
        $(DBUS_CFLAGS)                                  \
        $(GUDEV_CFLAGS)                                 \
        $(WEBKIT_FLAGS)                         \
-       -D__EXTENSIONS__ -D_BSD_SOURCE
+       -D__EXTENSIONS__
 
 
 shellincludedir = $(includedir)/rhythmbox/shell
diff --git a/tests/Makefile.am b/tests/Makefile.am
index ee77cb1..d1d6064 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -57,8 +57,7 @@ INCLUDES =                                                    \
        -I$(top_srcdir)/widgets                                 \
        -I$(top_srcdir)/rhythmdb                                \
        -I$(top_srcdir)/podcast                                 \
-       -I$(top_srcdir)/plugins/audioscrobbler                  \
-       -D_BSD_SOURCE
+       -I$(top_srcdir)/plugins/audioscrobbler
 
 if HAVE_CHECK
 TESTS += \
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]