[glom] ConnectionPool::connect(): Don't catch a Glib::Error just to throw it.



commit b6902b19a3d88729cbc1d4a74e7a1921c8667458
Author: Murray Cumming <murrayc murrayc com>
Date:   Thu Dec 4 19:00:24 2014 +0100

    ConnectionPool::connect(): Don't catch a Glib::Error just to throw it.
    
    This might deal with a Coverity Scan "Error Handling Issue".

 glom/libglom/connectionpool.cc |    9 +--------
 1 files changed, 1 insertions(+), 8 deletions(-)
---
diff --git a/glom/libglom/connectionpool.cc b/glom/libglom/connectionpool.cc
index 1aaa5c2..f34a869 100644
--- a/glom/libglom/connectionpool.cc
+++ b/glom/libglom/connectionpool.cc
@@ -326,14 +326,7 @@ sharedptr<SharedConnection> ConnectionPool::connect()
     }
     else
     {
-      try
-      {
-        m_refGdaConnection = m_backend->connect(m_database, get_user(), get_password(), m_fake_connection);
-      }
-      catch(const Glib::Error& ex)
-      {
-        throw ex;
-      }
+      m_refGdaConnection = m_backend->connect(m_database, get_user(), get_password(), m_fake_connection);
 
       {
         //Allow get_meta_store_data() to succeed:


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]