[ostree] fetcher: Close request body on error paths



commit c08a4503ced62e66418a4bc0c8cb519e783ca3b6
Author: Colin Walters <walters verbum org>
Date:   Wed Aug 20 10:23:28 2014 -0400

    fetcher: Close request body on error paths
    
    Otherwise, we're potentially holding up subsequent requests.
    
    I was hitting this when testing the metalink code, where we want to
    continue doing more fetches after hitting a 404.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=729585

 src/libostree/ostree-fetcher.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
---
diff --git a/src/libostree/ostree-fetcher.c b/src/libostree/ostree-fetcher.c
index 298ba63..3cc3533 100644
--- a/src/libostree/ostree-fetcher.c
+++ b/src/libostree/ostree-fetcher.c
@@ -505,6 +505,8 @@ on_request_sent (GObject        *object,
  out:
   if (local_error)
     {
+      if (pending->request_body)
+        (void) g_input_stream_close (pending->request_body, NULL, NULL);
       g_simple_async_result_take_error (pending->result, local_error);
       g_simple_async_result_complete (pending->result);
       g_object_unref (pending->result);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]