[epiphany] Always update location entry address if unfocused
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [epiphany] Always update location entry address if unfocused
- Date: Mon, 25 Aug 2014 14:14:16 +0000 (UTC)
commit 64451de8f7c611d50a5200e89278dc1c6c08c4ca
Author: Michael Catanzaro <mcatanzaro igalia com>
Date: Sun Aug 17 10:35:02 2014 -0500
Always update location entry address if unfocused
ephy-location-controller has some suspect code to lock the location
entry, preventing it from being changed when the current web page
changes. This is contrary to the behavior of Firefox, which immediately
updates the location entry when the page changes. I think Firefox's
behavior is less confusing, since it ensures the correct address is
always displayed, but I guess the intent of Epiphany's behavior is to
not change the address if the user is currently typing one.
The problem occurs when the location entry is focused while a new page
is loading: then the old address remains in the location entry, while
the title box subtitle gets updated to the new address. Fix this desync
by always updating the location entry address when the location entry is
unfocused. This means the location entry will only have the incorrect
address as long as it is visible, and will be updated to the correct
address when the title box is shown.
We might additionally want to remove all the locking code so that the
address is always immediately updated.
https://bugzilla.gnome.org/show_bug.cgi?id=734952
src/ephy-location-controller.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
---
diff --git a/src/ephy-location-controller.c b/src/ephy-location-controller.c
index a7ed552..cfec212 100644
--- a/src/ephy-location-controller.c
+++ b/src/ephy-location-controller.c
@@ -387,6 +387,7 @@ focus_out_event_cb (GtkWidget *entry,
{
priv->sync_address_is_blocked = FALSE;
g_signal_handlers_unblock_by_func (controller, G_CALLBACK (sync_address), entry);
+ sync_address (controller, NULL, entry);
}
return FALSE;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]