[gtksourceview/wip/undo-redo-more-tests] UndoManager: more unit tests

[Sébastien Wilmet <swilmet src gnome org>]

commit 958293b93279c15f2082425d69e4ede5bbd4970e
Author: Sébastien Wilmet <swilmet gnome org>
Date:   Sat Aug 23 15:12:18 2014 +0200

    UndoManager: more unit tests
    
    - test group of actions (insertions/deletions between begin/end user
    action).

 tests/test-undo-manager.c |  112 ++++++++++++++++++++++++++++++++++++++++-----
 1 files changed, 100 insertions(+), 12 deletions(-)
---
diff --git a/tests/test-undo-manager.c b/tests/test-undo-manager.c
index 5660ede..ee2515e 100644
--- a/tests/test-undo-manager.c
+++ b/tests/test-undo-manager.c
@@ -1,8 +1,8 @@
-/*
- * test-undo-manager.c
+/* -*- Mode: C; tab-width: 8; indent-tabs-mode: t; c-basic-offset: 8; coding: utf-8 -*- */
+/* test-undo-manager.c
  * This file is part of GtkSourceView
  *
- * Copyright (C) 2013 - Sébastien Wilmet <swilmet gnome org>
+ * Copyright (C) 2013, 2014 - Sébastien Wilmet <swilmet gnome org>
  *
  * GtkSourceView is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
@@ -24,11 +24,15 @@
 
 static void
 insert_text (GtkSourceBuffer *buffer,
-            gchar           *text)
+            const gchar     *text)
 {
-       gtk_text_buffer_begin_user_action (GTK_TEXT_BUFFER (buffer));
-       gtk_text_buffer_insert_at_cursor (GTK_TEXT_BUFFER (buffer), text, -1);
-       gtk_text_buffer_end_user_action (GTK_TEXT_BUFFER (buffer));
+       GtkTextBuffer *text_buffer = GTK_TEXT_BUFFER (buffer);
+       GtkTextIter iter;
+
+       gtk_text_buffer_begin_user_action (text_buffer);
+       gtk_text_buffer_get_end_iter (text_buffer, &iter);
+       gtk_text_buffer_insert (text_buffer, &iter, text, -1);
+       gtk_text_buffer_end_user_action (text_buffer);
 }
 
 static void
@@ -74,7 +78,8 @@ get_contents (GtkSourceBuffer *buffer)
 }
 
 static void
-check_max_undo_levels (GtkSourceBuffer *buffer)
+check_max_undo_levels (GtkSourceBuffer *buffer,
+                      gboolean         several_user_actions)
 {
        gint max_levels = gtk_source_buffer_get_max_undo_levels (buffer);
        gint nb_redos = 0;
@@ -102,7 +107,17 @@ check_max_undo_levels (GtkSourceBuffer *buffer)
        /* Add max_levels+1 actions */
        for (i = 0; i <= max_levels; i++)
        {
-               insert_text (buffer, "foobar\n");
+               if (several_user_actions)
+               {
+                       gtk_text_buffer_begin_user_action (GTK_TEXT_BUFFER (buffer));
+                       insert_text (buffer, "foobar\n");
+                       delete_char_at_offset (buffer, 0);
+                       gtk_text_buffer_end_user_action (GTK_TEXT_BUFFER (buffer));
+               }
+               else
+               {
+                       insert_text (buffer, "foobar\n");
+               }
        }
 
        /* Check number of possible undos */
@@ -183,6 +198,10 @@ static void
 test_max_undo_levels (void)
 {
        GtkSourceBuffer *buffer = gtk_source_buffer_new (NULL);
+
+       /* FIXME max_undo_levels of 0 doesn't work as expected (i.e. undo/redo
+        * disabled).
+        */
 #if 0
        gint min = 0;
 #else
@@ -195,19 +214,22 @@ test_max_undo_levels (void)
        for (i = min; i <= max; i++)
        {
                gtk_source_buffer_set_max_undo_levels (buffer, i);
-               check_max_undo_levels (buffer);
+               check_max_undo_levels (buffer, FALSE);
+               check_max_undo_levels (buffer, TRUE);
        }
 
        /* Decrease */
        for (i = max; i >= min; i--)
        {
                gtk_source_buffer_set_max_undo_levels (buffer, i);
-               check_max_undo_levels (buffer);
+               check_max_undo_levels (buffer, FALSE);
+               check_max_undo_levels (buffer, TRUE);
        }
 
        /* can redo: TRUE -> FALSE */
        gtk_source_buffer_set_max_undo_levels (buffer, 3);
-       check_max_undo_levels (buffer);
+       check_max_undo_levels (buffer, FALSE);
+       check_max_undo_levels (buffer, TRUE);
 
        while (gtk_source_buffer_can_redo (buffer))
        {
@@ -479,6 +501,69 @@ test_merge_actions (void)
        g_object_unref (buffer);
 }
 
+static void
+test_several_user_actions (void)
+{
+       GtkSourceBuffer *source_buffer = gtk_source_buffer_new (NULL);
+       GtkTextBuffer *text_buffer = GTK_TEXT_BUFFER (source_buffer);
+       GList *contents_history = g_list_append (NULL, get_contents (source_buffer));
+       GtkTextIter iter;
+
+       gtk_source_buffer_set_max_undo_levels (source_buffer, -1);
+
+       /* Contiguous insertions */
+       gtk_text_buffer_begin_user_action (text_buffer);
+       insert_text (source_buffer, "hello\n");
+       insert_text (source_buffer, "world\n");
+       gtk_text_buffer_end_user_action (text_buffer);
+
+       contents_history = g_list_append (contents_history, get_contents (source_buffer));
+       check_contents_history (source_buffer, contents_history);
+
+       /* Non-contiguous insertions */
+       gtk_text_buffer_begin_user_action (text_buffer);
+       gtk_text_buffer_get_iter_at_offset (text_buffer, &iter, 0);
+       gtk_text_buffer_insert (text_buffer, &iter, "a", -1);
+       gtk_text_buffer_get_iter_at_offset (text_buffer, &iter, 2);
+       gtk_text_buffer_insert (text_buffer, &iter, "b", -1);
+       gtk_text_buffer_end_user_action (text_buffer);
+
+       contents_history = g_list_append (contents_history, get_contents (source_buffer));
+       check_contents_history (source_buffer, contents_history);
+
+       /* Non-contiguous deletions (removes the 'a' and 'b' just inserted). */
+       gtk_text_buffer_begin_user_action (text_buffer);
+       delete_char_at_offset (source_buffer, 2);
+       delete_char_at_offset (source_buffer, 0);
+       gtk_text_buffer_end_user_action (text_buffer);
+
+       contents_history = g_list_append (contents_history, get_contents (source_buffer));
+       check_contents_history (source_buffer, contents_history);
+
+       /* Contiguous deletions */
+       gtk_text_buffer_begin_user_action (text_buffer);
+       delete_first_line (source_buffer);
+       delete_first_line (source_buffer);
+       gtk_text_buffer_end_user_action (text_buffer);
+
+       contents_history = g_list_append (contents_history, get_contents (source_buffer));
+       check_contents_history (source_buffer, contents_history);
+
+       /* Mixed insertions/deletions */
+       gtk_text_buffer_begin_user_action (text_buffer);
+       gtk_text_buffer_set_text (text_buffer, "ahbello\n", -1);
+       delete_char_at_offset (source_buffer, 2);
+       delete_char_at_offset (source_buffer, 0);
+       insert_text (source_buffer, "world\n");
+       gtk_text_buffer_end_user_action (text_buffer);
+
+       contents_history = g_list_append (contents_history, get_contents (source_buffer));
+       check_contents_history (source_buffer, contents_history);
+
+       g_list_free_full (contents_history, g_free);
+       g_object_unref (source_buffer);
+}
+
 int
 main (int argc, char **argv)
 {
@@ -505,5 +590,8 @@ main (int argc, char **argv)
        g_test_add_func ("/UndoManager/test-merge-actions",
                         test_merge_actions);
 
+       g_test_add_func ("/UndoManager/test-several-user-actions",
+                        test_several_user_actions);
+
        return g_test_run ();
 }