[smuxi/experiments/new_chat_sync_manager: 3/7] Frontend: stop using Activator.CreateInstance()

[Mirco M. M. Bauer <mmmbauer src gnome org>]

commit d8c40db9ecaf25dd3a429ae7acb8a6dca1f87511
Author: Andrés G. Aragoneses <knocte gmail com>
Date:   Tue Jul 22 17:20:42 2014 +0200

    Frontend: stop using Activator.CreateInstance()
    
    This could have blown up at runtime, as it was reflectionish.

 src/Frontend/ChatViewSyncManager.cs |   37 ++++++++++++++++++-----------------
 1 files changed, 19 insertions(+), 18 deletions(-)
---
diff --git a/src/Frontend/ChatViewSyncManager.cs b/src/Frontend/ChatViewSyncManager.cs
index d44b245..09cf4d1 100644
--- a/src/Frontend/ChatViewSyncManager.cs
+++ b/src/Frontend/ChatViewSyncManager.cs
@@ -108,7 +108,7 @@ namespace Smuxi.Frontend
             public override void ExecuteAdd()
             {
                 Trace.Call(Chat.ChatModel);
-                Chat.SetState<AddedState>();
+                Chat.State = new AddedState(Chat);
             }
         }
 
@@ -152,19 +152,19 @@ namespace Smuxi.Frontend
             public override void ExecuteReadyToSync()
             {
                 Trace.Call(Chat.ChatModel);
-                Chat.SetState<WaitingForSyncState>();
+                Chat.State = new WaitingForSyncState(Chat);
             }
 
             public override void ExecuteSync()
             {
                 Trace.Call(Chat.ChatModel);
-                Chat.SetState<SyncQueuedState>();
+                Chat.State = new SyncQueuedState(Chat);
             }
 
             public override void ExecuteRemove()
             {
                 Trace.Call(Chat.ChatModel);
-                Chat.SetState<RemovingState>();
+                Chat.State = new RemovingState(Chat);
             }
         }
 
@@ -178,7 +178,7 @@ namespace Smuxi.Frontend
             public override void ExecuteReadyToSync()
             {
                 Trace.Call(Chat.ChatModel);
-                Chat.SetState<SyncingState>();
+                Chat.State = new SyncingState(Chat);
             }
         }
 
@@ -192,13 +192,13 @@ namespace Smuxi.Frontend
             public override void ExecuteSync()
             {
                 Trace.Call(Chat.ChatModel);
-                Chat.SetState<SyncingState>();
+                Chat.State = new SyncingState(Chat);
             }
 
             public override void ExecuteRemove()
             {
                 Trace.Call(Chat.ChatModel);
-                Chat.SetState<RemovingState>();
+                Chat.State = new RemovingState(Chat);
             }
         }
 
@@ -227,7 +227,7 @@ namespace Smuxi.Frontend
             public override void ExecuteSyncFinished()
             {
                 Trace.Call(Chat.ChatModel);
-                Chat.SetState<SyncState>();
+                Chat.State = new SyncState(Chat);
             }
         }
 
@@ -241,14 +241,14 @@ namespace Smuxi.Frontend
             public override void ExecuteRemove()
             {
                 Trace.Call(Chat.ChatModel);
-                Chat.SetState<RemovingState>();
+                Chat.State = new RemovingState(Chat);
             }
 
             public override void ExecuteSync()
             {
                 // this happens for example in /rejoin
                 Trace.Call(Chat.ChatModel);
-                Chat.SetState<SyncingState>();
+                Chat.State = new SyncingState(Chat);
             }
         }
 
@@ -281,22 +281,23 @@ namespace Smuxi.Frontend
         class SyncInfo
         {
             internal readonly ChatViewSyncManager Manager;
-            internal State State { private set; get; }
+            internal State State {
+                get { return f_State; }
+                set {
+                    f_State = value;
+                    f_State.Init();
+                }
+            }
             internal readonly ChatModel ChatModel;
             internal IChatView ChatView { get; set; }
             readonly object syncRoot = new object();
+            State f_State;
 
             public SyncInfo(ChatViewSyncManager manager, ChatModel chatModel)
             {
                 Manager = manager;
                 ChatModel = chatModel;
-                SetState<InitialState>();
-            }
-
-            internal void SetState<T>() where T : State
-            {
-                State = (T)Activator.CreateInstance(typeof(T), this);
-                State.Init();
+                State = new InitialState(this);
             }
 
             public void ExecuteAdd()