[gimp] fix some pieces of nonsensical code



commit 9a8d2f577e2bd4e5d97fe5c9d0a11b26d774d5bc
Author: Simon Budig <simon budig de>
Date:   Fri Aug 15 22:55:48 2014 +0200

    fix some pieces of nonsensical code
    
    Spotted by Andrey Karpov using static code analysis:
       http://www.viva64.com/en/b/0273/

 app/paint/gimpink-blob.c    |    6 +++---
 plug-ins/gfig/gfig-dialog.c |    1 -
 2 files changed, 3 insertions(+), 4 deletions(-)
---
diff --git a/app/paint/gimpink-blob.c b/app/paint/gimpink-blob.c
index 126cde9..08d5622 100644
--- a/app/paint/gimpink-blob.c
+++ b/app/paint/gimpink-blob.c
@@ -159,7 +159,7 @@ gimp_blob_square (gdouble xc,
 
   /* Make sure we order points ccw */
 
-  if (xp * yq - yq * xp < 0)
+  if (xp * yq - xq * yp < 0)
     {
       xq = -xq;
       yq = -yq;
@@ -192,7 +192,7 @@ gimp_blob_diamond (gdouble xc,
 
   /* Make sure we order points ccw */
 
-  if (xp * yq - yq * xp < 0)
+  if (xp * yq - xq * yp < 0)
     {
       xq = -xq;
       yq = -yq;
@@ -275,7 +275,7 @@ gimp_blob_ellipse (gdouble xc,
 
   /* Make sure we traverse ellipse in ccw direction */
 
-  if (xp * yq - yq * xp < 0)
+  if (xp * yq - xq * yp < 0)
     {
       xq = -xq;
       yq = -yq;
diff --git a/plug-ins/gfig/gfig-dialog.c b/plug-ins/gfig/gfig-dialog.c
index 0ed0105..81df70e 100644
--- a/plug-ins/gfig/gfig-dialog.c
+++ b/plug-ins/gfig/gfig-dialog.c
@@ -1620,7 +1620,6 @@ save_file_chooser_response (GtkFileChooser *chooser,
 
       gfig_context->current_obj = obj;
       gfig_save_callbk ();
-      gfig_context->current_obj = gfig_context->current_obj;
     }
 
   gtk_widget_destroy (GTK_WIDGET (chooser));


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]