[easytag/wip/application-window: 2/70] Avoid a GtkApplication assertion



commit f49511c3e5a5835c9cbd9840ed103bbc0e403b31
Author: Santtu Lakkala <inz inz fi>
Date:   Thu Apr 24 08:48:52 2014 +0300

    Avoid a GtkApplication assertion
    
    Realizaing an application window during construction triggers an
    assertion with older versions of GTK+, and a warning with newer ones, so
    only show the window after it has been associated with the application.

 src/application_window.c |    2 +-
 src/easytag.c            |    2 ++
 2 files changed, 3 insertions(+), 1 deletions(-)
---
diff --git a/src/application_window.c b/src/application_window.c
index 151206e..f321dac 100644
--- a/src/application_window.c
+++ b/src/application_window.c
@@ -1803,7 +1803,7 @@ et_application_window_init (EtApplicationWindow *self)
     widget = Create_Progress_Bar ();
     gtk_box_pack_end (GTK_BOX (hbox), widget, FALSE, FALSE, 0);
 
-    gtk_widget_show_all (GTK_WIDGET (self));
+    gtk_widget_show_all (GTK_WIDGET (main_vbox));
 }
 
 static void
diff --git a/src/easytag.c b/src/easytag.c
index 659c44c..ebc7a34 100644
--- a/src/easytag.c
+++ b/src/easytag.c
@@ -134,6 +134,8 @@ common_init (GApplication *application)
     window = et_application_window_new (GTK_APPLICATION (application));
     MainWindow = GTK_WIDGET (window);
 
+    gtk_widget_show (MainWindow);
+
     /* Starting messages */
     Log_Print(LOG_OK,_("Starting EasyTAG version %s (PID: %d)…"),PACKAGE_VERSION,getpid());
 #ifdef ENABLE_MP3


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]