[orca] Do not blanket-disable caret navigation in ARIA content in Gecko



commit 3021f3e2bc210a033166077543a72fdb2536b730
Author: Joanmarie Diggs <jdiggs igalia com>
Date:   Wed Aug 6 10:32:21 2014 -0400

    Do not blanket-disable caret navigation in ARIA content in Gecko
    
    Equating "ARIA" with "totally navigable and Orca should get out of the way"
    is proving to be a bad idea, making pages which in theory should be more
    accessible less accessible.

 src/orca/scripts/toolkits/Gecko/script.py |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)
---
diff --git a/src/orca/scripts/toolkits/Gecko/script.py b/src/orca/scripts/toolkits/Gecko/script.py
index 9628148..8e2dae5 100644
--- a/src/orca/scripts/toolkits/Gecko/script.py
+++ b/src/orca/scripts/toolkits/Gecko/script.py
@@ -1730,9 +1730,6 @@ class Script(default.Script):
         if not self.inDocumentContent():
             return False
 
-        if not self.isNavigableAria(orca_state.locusOfFocus):
-            return False
-
         if keyboardEvent.event_string in ["Page_Up", "Page_Down"]:
             return False
 
@@ -1766,6 +1763,10 @@ class Script(default.Script):
             if keyboardEvent.event_string in ["Home", "End"]:
                 return False
 
+            if obj.parent.getRole() == pyatspi.ROLE_COMBO_BOX \
+              and keyboardEvent.event_string in ["Up", "Down"]:
+               return False
+
             # We want to use our caret navigation model in an entry if
             # there's nothing in the entry, we're at the beginning of
             # the entry and press Left or Up, or we're at the end of the


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]