[gnome-shell/wip/overviewTransitions: 3/4] overviewControls: don't override explicit calls to slideIn



commit 4f24514bc06a00c460dbb65d2adfb2dae055a557
Author: Carlos Soriano <carlos soriano89 gmail com>
Date:   Sat Jul 26 17:36:17 2014 +0200

    overviewControls: don't override explicit calls to slideIn
    
    Currently we are overriding the explicit calls to slideIn
    given that it's called also with the signal of showing overview.
    
    It was necesary because of the bug that previous patch fixed,
    so now we can just delete that.

 js/ui/overviewControls.js |   10 ++--------
 1 files changed, 2 insertions(+), 8 deletions(-)
---
diff --git a/js/ui/overviewControls.js b/js/ui/overviewControls.js
index b396ff0..261c103 100644
--- a/js/ui/overviewControls.js
+++ b/js/ui/overviewControls.js
@@ -118,7 +118,6 @@ const SlidingControl = new Lang.Class({
                                      style_class: 'overview-controls',
                                      clip_to_allocation: true });
 
-        Main.overview.connect('showing', Lang.bind(this, this._onOverviewShowing));
         Main.overview.connect('hiding', Lang.bind(this, this._onOverviewHiding));
 
         Main.overview.connect('item-drag-begin', Lang.bind(this, this._onDragBegin));
@@ -177,14 +176,9 @@ const SlidingControl = new Lang.Class({
                                         transition: 'easeOutQuad' });
     },
 
-    _onOverviewShowing: function() {
-        this._visible = true;
-        this.layout.slideX = this._getSlide();
-        this.layout.translationX = this._getTranslation();
-        this.slideIn();
-    },
-
     _onOverviewHiding: function() {
+        // We need to explicitily slideOut since showing pages
+        // doesn't implies to slide out, instead, hiding the overview does.
         this.slideOut();
     },
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]