[gnome-online-accounts/rhel-7.1: 7/34] kerberos: fix principal leak in identity_renew
- From: Debarshi Ray <debarshir src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-online-accounts/rhel-7.1: 7/34] kerberos: fix principal leak in identity_renew
- Date: Mon, 4 Aug 2014 13:42:31 +0000 (UTC)
commit 64631abe295f5f3c424751ea52b694fab02600f1
Author: Debarshi Ray <debarshir gnome org>
Date: Mon Mar 17 09:42:13 2014 -0400
kerberos: fix principal leak in identity_renew
The code carefully freed the principal in all error cases, but then
failed to free the principal in the non-error case!
https://bugzilla.gnome.org/show_bug.cgi?id=726353
src/goaidentity/goakerberosidentity.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
---
diff --git a/src/goaidentity/goakerberosidentity.c b/src/goaidentity/goakerberosidentity.c
index ddbad75..d8c5c66 100644
--- a/src/goaidentity/goakerberosidentity.c
+++ b/src/goaidentity/goakerberosidentity.c
@@ -1406,6 +1406,9 @@ goa_kerberos_identity_renew (GoaKerberosIdentity *self, GError **error)
goa_debug ("GoaKerberosIdentity: identity %s renewed", name);
renewed = TRUE;
+
+ krb5_free_principal (self->priv->kerberos_context, principal);
+
out:
g_free (name);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]