[folks] bluez: Add a test for an empty ‘FN ’ attribute
- From: Philip Withnall <pwithnall src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [folks] bluez: Add a test for an empty ‘FN ’ attribute
- Date: Tue, 29 Apr 2014 11:03:22 +0000 (UTC)
commit 83e7b9b4c6a9ca79ba3a55f836306fb6c657a605
Author: Philip Withnall <philip withnall collabora co uk>
Date: Tue Apr 29 12:02:50 2014 +0100
bluez: Add a test for an empty ‘FN’ attribute
This has tripped up other vCard parsers in the past. Thankfully, it
seems fine with EDS for us.
tests/bluez/vcard-parsing.vala | 19 +++++++++++++++++--
1 files changed, 17 insertions(+), 2 deletions(-)
---
diff --git a/tests/bluez/vcard-parsing.vala b/tests/bluez/vcard-parsing.vala
index f9e9100..d54b98e 100644
--- a/tests/bluez/vcard-parsing.vala
+++ b/tests/bluez/vcard-parsing.vala
@@ -147,7 +147,16 @@ public class VcardParsingTests : BluezTest.TestCase
"VERSION:3.0\n" +
"FN:Alex Lawson\n" +
"N:Lawson;Alex\n" +
- "END:VCARD\n");
+ "END:VCARD\n" +
+ "\n" +
+ /* Empty FN attribute: treat it as unset. */
+ "BEGIN:VCARD\n" +
+ "VERSION:3.0\n" +
+ "N:W;Alice;;;\n" +
+ "FN:\n" +
+ "TEL;TYPE=CELL:5145152\n" +
+ "TEL;TYPE=VOICE:545\n" +
+ "END:VCARD");
/* Set up the aggregator and wait until either the expected persona are
* seen, or the test times out and fails. */
@@ -160,7 +169,8 @@ public class VcardParsingTests : BluezTest.TestCase
"Franco Dianno",
"Amelia Smith",
"Sadie Jones",
- "Alex Lawson"
+ "Alex Lawson",
+ "" /* Alice W */
});
/* Check the properties of our individuals. */
@@ -191,6 +201,11 @@ public class VcardParsingTests : BluezTest.TestCase
ind = TestUtils.get_individual_by_name (aggregator, "Alex Lawson");
expected_name = new StructuredName ("Lawson", "Alex", null, null, null);
assert (ind.structured_name.equal (expected_name));
+
+ ind = TestUtils.get_individual_by_name (aggregator, "");
+ expected_name = new StructuredName ("W", "Alice", null, null, null);
+ assert (ind.structured_name.equal (expected_name));
+ assert (ind.full_name == "");
}
/* Test that vCards with weird encodings are parsed correctly. */
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]