[rhythmbox] Allow syncing with a device without enough space



commit 26d0551dcb9a4bec6d63313246060743ed3dd2fd
Author: Marc Plano-Lesay <marc planolesay gmail com>
Date:   Fri Apr 4 19:58:23 2014 +0200

    Allow syncing with a device without enough space
    
    When using Rhythmbox to transcode on the fly music from FLAC to a lighter format
    like OGG, the available size is checked against the FLAC files, which can
    prevent an user to sync even if there's enough space for the compressed files.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=632266

 sources/rb-media-player-source.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)
---
diff --git a/sources/rb-media-player-source.c b/sources/rb-media-player-source.c
index 58dba0d..2004f68 100644
--- a/sources/rb-media-player-source.c
+++ b/sources/rb-media-player-source.c
@@ -661,20 +661,24 @@ update_sync_settings_dialog (RBMediaPlayerSource *source)
 {
        RBMediaPlayerSourcePrivate *priv = MEDIA_PLAYER_SOURCE_GET_PRIVATE (source);
        gboolean can_continue;
+       gboolean show_error;
 
        if (sync_has_items_enabled (source) == FALSE) {
                can_continue = FALSE;
+               show_error = TRUE;
                gtk_label_set_text (GTK_LABEL (priv->sync_dialog_label),
                                    _("You have not selected any music, playlists, or podcasts to transfer to 
this device."));
        } else if (sync_has_enough_space (source) == FALSE) {
-               can_continue = FALSE;
+               can_continue = TRUE;
+               show_error = TRUE;
                gtk_label_set_text (GTK_LABEL (priv->sync_dialog_label),
                                    _("There is not enough space on the device to transfer the selected 
music, playlists and podcasts."));
        } else {
                can_continue = TRUE;
+               show_error = FALSE;
        }
 
-       gtk_widget_set_visible (priv->sync_dialog_error_box, !can_continue);
+       gtk_widget_set_visible (priv->sync_dialog_error_box, show_error);
        gtk_dialog_set_response_sensitive (GTK_DIALOG (priv->sync_dialog), GTK_RESPONSE_YES, can_continue);
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]