[gparted] Place partition information LVM2 member names in string list (#690542)



commit c0529abf363ed323c2f1ef1564e414f3b39517a8
Author: Curtis Gedak <gedakc gmail com>
Date:   Thu Apr 24 12:53:41 2014 -0600

    Place partition information LVM2 member names in string list (#690542)
    
    Placing the LVM2 member names in a string list enables the member names
    to be selected all at once by a user.  This was not possible with
    separate label widgets for each LVM2 member name.
    
    Bug 690542 - Partition Information Dialog Warning not readable

 src/Dialog_Partition_Info.cc |   16 +++++++---------
 1 files changed, 7 insertions(+), 9 deletions(-)
---
diff --git a/src/Dialog_Partition_Info.cc b/src/Dialog_Partition_Info.cc
index d9edc3b..89645e3 100644
--- a/src/Dialog_Partition_Info.cc
+++ b/src/Dialog_Partition_Info.cc
@@ -391,19 +391,17 @@ void Dialog_Partition_Info::Display_Info()
                if ( ! vgname .empty() )
                        members = lvm2_pv_info .get_vg_members( vgname ) ;
 
-               if ( members .empty() )
-                       table ->attach( * Utils::mk_label( "" ), 2, 3, top++, bottom++, Gtk::FILL ) ;
-               else
+               Glib::ustring members_str = "" ;
+               if ( ! members .empty() )
                {
-                       table ->attach( * Utils::mk_label( members [0], true, false, true ),
-                                       2, 3, top++, bottom++, Gtk::FILL ) ;
-                       for ( unsigned int i = 1 ; i < members .size() ; i ++ )
+                       for ( unsigned int i = 0 ; i < members .size() ; i ++ )
                        {
-                               table ->attach( * Utils::mk_label( "" ), 0, 1, top, bottom, Gtk::FILL) ;
-                               table ->attach( * Utils::mk_label( members [i], true, false, true ),
-                                               2, 3, top++, bottom++, Gtk::FILL ) ;
+                               if ( i > 0 )
+                                       members_str += "\n" ;
+                               members_str += members[i] ;
                        }
                }
+               table ->attach( * Utils::mk_label( members_str, true, false, true ), 2, 3, top++, bottom++, 
Gtk::FILL ) ;
        }
 
        //Right field & value pair area


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]