[gnome-shell] search: Make sure to destroy old provider displays when we unregister
- From: Jasper St. Pierre <jstpierre src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] search: Make sure to destroy old provider displays when we unregister
- Date: Tue, 22 Apr 2014 03:37:07 +0000 (UTC)
commit a83b9ed6d784a77c2772d32a591b44a11cf60822
Author: Jasper St. Pierre <jstpierre mecheye net>
Date: Mon Apr 21 23:34:11 2014 -0400
search: Make sure to destroy old provider displays when we unregister
When we unregistered providers, like when we refreshed the list of
active remote providers, we would forget to destroy the old provider
display after the fact. This left an empty "skeleton" provider display
still in the search results that would never be filled in. Make sure
to destroy it properly.
https://bugzilla.gnome.org/show_bug.cgi?id=728597
js/ui/search.js | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
---
diff --git a/js/ui/search.js b/js/ui/search.js
index 919642a..3797b74 100644
--- a/js/ui/search.js
+++ b/js/ui/search.js
@@ -68,6 +68,9 @@ const SearchSystem = new Lang.Class({
_unregisterProvider: function (provider) {
let index = this._providers.indexOf(provider);
this._providers.splice(index, 1);
+
+ if (provider.display)
+ provider.display.destroy();
},
getProviders: function() {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]