[cluttermm/cluttermm-1-18] Actor: Ignore destroy() and the destroy signal.



commit 18f6d9712fb02b74385ec19cd4bea38d909e240b
Author: Murray Cumming <murrayc murrayc com>
Date:   Thu Apr 17 09:41:18 2014 +0200

    Actor: Ignore destroy() and the destroy signal.
    
    They are too strange.

 clutter/src/actor.hg |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)
---
diff --git a/clutter/src/actor.hg b/clutter/src/actor.hg
index 02551aa..0774705 100644
--- a/clutter/src/actor.hg
+++ b/clutter/src/actor.hg
@@ -127,9 +127,8 @@ public:
 #m4 dnl // Those are varargs convenience functions for C coders
   _IGNORE(clutter_actor_animate, clutter_actor_animate_with_alpha, clutter_actor_animate_with_timeline)
 
-  //TODO: Check that we don't want to wrap this: _WRAP_METHOD(void destroy(), clutter_actor_destroy)
-  //_IGNORE(clutter_actor_destroy)
-  _WRAP_METHOD(void destroy(), clutter_actor_destroy)
+  //We ignore clutter_actor_destroy because it would break any existing RefPtr.
+  _IGNORE(clutter_actor_destroy)
 
   _WRAP_METHOD(Glib::RefPtr<Pango::Context> get_pango_context(),
                clutter_actor_get_pango_context, refreturn)
@@ -528,7 +527,10 @@ _DEPRECATE_IFDEF_END
   _WRAP_SIGNAL(bool leave_event(CrossingEvent* event), "leave_event")
   _WRAP_SIGNAL(void show(), "show")
   _WRAP_SIGNAL(void hide(), "hide")
-  _WRAP_SIGNAL(void destroy(), "destroy")
+
+  //We ignore the destroy signal because it would just encourage strange memory management. 
+  _IGNORE_SIGNAL(void destroy(), "destroy")
+
   _WRAP_SIGNAL(bool key_release_event(KeyEvent* event), "key_release_event")
   _WRAP_SIGNAL(bool enter_event(CrossingEvent* event), "enter_event")
   _WRAP_SIGNAL(bool event(Event* event), "event")


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]