[glib] Bug 724590 - GSlice slab_stack corruption
- From: John Ralls <jralls src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glib] Bug 724590 - GSlice slab_stack corruption
- Date: Wed, 16 Apr 2014 00:27:36 +0000 (UTC)
commit c49ec3c8d7a90589308ce1b87a92bc627335ffd2
Author: John Ralls <jralls ceridwen us>
Date: Mon Feb 17 15:51:38 2014 -0800
Bug 724590 - GSlice slab_stack corruption
Dereference allocation->contention_counters before trying to take the
address of an element.
glib/gslice.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
---
diff --git a/glib/gslice.c b/glib/gslice.c
index 0563d80..2c5f4fb 100644
--- a/glib/gslice.c
+++ b/glib/gslice.c
@@ -715,7 +715,8 @@ static ChunkLink*
magazine_cache_pop_magazine (guint ix,
gsize *countp)
{
- g_mutex_lock_a (&allocator->magazine_mutex, &allocator->contention_counters[ix]);
+ guint *counters = allocator->contention_counters;
+ g_mutex_lock_a (&allocator->magazine_mutex, &counters[ix]);
if (!allocator->magazines[ix])
{
guint magazine_threshold = allocator_get_magazine_threshold (allocator, ix);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]